10000 feat(index): add sourcemap support (`options.sourceMap`) by driskell · Pull Request #59 · webpack-contrib/script-loader · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Nov 5, 2019. It is now read-only.

feat(index): add sourcemap support (options.sourceMap) #59

Closed
wants to merge 1 commit into from

Conversation

driskell
Copy link
@driskell driskell commented Sep 26, 2018

Currently, we only get the source map if web pack is in debug mode. This adds the sourceMap parameter that will also add it.

Type

  • Feature

Issues

SemVer

  • Minor

Currently, we only get the source map if web pack is in debug mode. This adds the sourceMap parameter that will also add it.
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@driskell
Copy link
Author

I'll pick some bits from the other PR later and sign CLI.

@@ -9,7 +9,7 @@ module.exports.pitch = function(remainingRequest) {
return "require(" + JSON.stringify("!!" + path.join(__dirname, "addScript.js")) + ")"+
"(require(" +
JSON.stringify("!!" + require.resolve("raw-loader") + "!" + remainingRequest) + ")" +
(this.debug ?
(this.debug || (this.query && this.query.sourceMap) ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aymasse
Copy link
Contributor
aymasse commented Jan 7, 2019

Hello,

This PR could really be useful for my team at work, and seeing it did not have any activity in the past months, I took the liberty to apply changes suggested by @michael-ciniawsky in PR #61

@driskell
Copy link
Author

Closing in favor of #61 :)

@driskell driskell closed this Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0