decode URI when aborting transition (Fix #760) #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfmelicor
approved these changes
Dec 21, 2016
|
Any idea when this will be merged? @dfmelicor |
posva
reviewed
Jan 13, 2017
| @@ -45,7 +46,8 @@ export default class RouteTransition { | |||
| // on initial load, it gets caught in an infinite loop. | |||
| const abortingOnLoad = !this.from.path && this.to.path === '/' | |||
| if (!abortingOnLoad) { | |||
| this.router.replace(this.from.path || '/') | |||
| const path = this.from.path ? tryDecode(this.from.path, true) : '/' | |||
There was a problem hiding this comment.
Can you add a little comment over here to point out why we need to call tryDecode?
posva
approved these changes
Jan 13, 2017
fnlctrl
approved these changes
Jan 15, 2017
znck
approved these changes
Jan 16, 2017
kazupon
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fixes #760)
Problem
When aborting a transition, and the URL contained escaped chars, the chars would be escaped again. I added a decode in between to make this work again.