URL parameters are re-encoded when aborting a transition #760

dfmelicor · 2016-10-12T07:40:57Z

If any parameter contains a URL encoded value, the value is re-encoded when the transition is aborted.

If the current URL is http://website.com/#!/accounts?PARAM=%20, calling transition#abort redirects to http://website.com/#!/accounts?PARAM=%25%20 instead of the original URL.

Checking transition#abort, it seems the call to #stringifyPath performs the double encoding when a String parameter is passed.

The text was updated successfully, but these errors were encountered:

LinusBorg · 2016-10-12T07:55:18Z

Hi @dfmelicor

Thanks for filing this issue! Could you please provide a small reporduction on jsfiddle so we can debug this without trying to replicate this ourselves?`

That would be very helpful, thanks!

dfmelicor · 2016-10-12T09:04:38Z

Hi @LinusBorg

Please see: https://jsfiddle.net/dfmelicor/ehgtkpa2/2/

You can click Navigate to go to a random link. Ticking the Abort Transition checkbox before clicking Navigate reproduces the problem.

It seems to be replicable using the following versions:

Vue 1.0.28
Vue Router 0.7.13

Thank you!

LinusBorg · 2016-10-12T22:25:45Z

Thanks for the fiddle.

We will take care of this.

dfmelicor · 2016-10-13T02:01:52Z

Thank you!

Appreciate all the work you guys are doing.

LinusBorg · 2016-11-12T21:20:38Z

Will send PR tomorrow.

BreakingDev · 2016-12-01T10:41:33Z

@LinusBorg Any update on this?

LinusBorg · 2016-12-01T11:14:06Z

Dang, totally forgot about this one. Hope I have time to push this tonight, if not it has to wait until the weekend.

LinusBorg · 2016-12-14T19:40:27Z

Finally came around to making this PR

* init commit * add comment explaining the change.

dfmelicor · 2017-01-25T04:24:32Z

@LinusBorg Will a new build of vue-router be created to include this change? Or we should just build on our own?

LinusBorg · 2017-01-25T08:57:18Z

We will surely release a new version of the 0.7 branch which includes this fix.

We will have to ask @yyx990803 about the timeline though.

dfmelicor · 2017-01-25T08:58:21Z

@LinusBorg Got it. Looking forward to the next release.

dfmelicor · 2017-01-30T01:59:28Z

@LinusBorg We're trying out the fix now, but encountering a different problem with encoding. Colons and slashes don't seem to be encoded after the abort.

e.g.:
Original URL, where PARAM = :

http://example.com/!#/path?PARAM=%3A

It is expected that on abort, URL remains unchanged. But the actual behavior is, the URL now becomes

http://example.com/!#/path?PARAM=:

I think the problem is with the ff. call in RouteTransition#abort

const path = this.from.path ? tryDecode(this.from.path, true) : '/'

Shouldn't the second parameter be false?

LinusBorg added the need repro label Oct 12, 2016

LinusBorg added bug 1.x and removed need repro labels Oct 12, 2016

LinusBorg self-assigned this Oct 19, 2016

LinusBorg mentioned this issue Dec 14, 2016

decode URI when aborting transition (Fix #760) #1020

Merged

LinusBorg removed their assignment Dec 14, 2016

yyx990803 pushed a commit that referenced this issue Jan 16, 2017

decode URI when aborting transition (Fix #760) (#1020)

efadecc

* init commit * add comment explaining the change.

posva closed this as completed Jul 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

URL parameters are re-encoded when aborting a transition #760

URL parameters are re-encoded when aborting a transition #760

URL parameters are re-encoded when aborting a transition #760

URL parameters are re-encoded when aborting a transition #760

Comments