8000 Fixes: __vfrag__ references prevent GC of Vue objects by elsassph · Pull Request #2162 · vuejs/vue · GitHub
[go: up one dir, main page]

Skip to content

Fixes: __vfrag__ references prevent GC of Vue objects #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2016

Conversation

elsassph
Copy link

See issue #2161

@@ -181,6 +181,9 @@ Fragment.prototype.destroy = function () {
if (this.parentFrag) {
this.parentFrag.childFrags.$remove(this)
}
if (this.node) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.node will always be present, we can remove the if check here

yyx990803 added a commit that referenced this pull request Jan 15, 2016
Fixes: __vfrag__ references prevent GC of Vue objects
@yyx990803 yyx990803 merged commit f57ea7c into vuejs:dev Jan 15, 2016
@elsassph elsassph deleted the fix-2161-dev branch January 15, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0