8000 Fixes: __vfrag__ references prevent GC of Vue objects by elsassph · Pull Request #2162 · vuejs/vue · GitHub
[go: up one dir, main page]
Skip to content

Fixes: __vfrag__ references prevent GC of Vue objects #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Fixes: __vfrag__ references prevent GC of Vue objects #2162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb8775d
Fixes: __vfrag__ references prevent GC of Vue objects #2161
Jan 14, 2016
f3e79b7
Removed `this.node` null check guard.
Jan 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixes: __vfrag__ references prevent GC of Vue objects #2161
  • Loading branch information
Philippe Elsass committed Jan 14, 2016
commit fb8775dfcabd66f4acc07fc49fdf5c378fd9570b
3 changes: 3 additions & 0 deletions src/fragment/fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ Fragment.prototype.destroy = function () {
if (this.parentFrag) {
this.parentFrag.childFrags.$remove(this)
}
if (this.node) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.node will always be present, we can remove the if check here

this.node.__vfrag__ = null
}
this.unlink()
}

Expand Down
0