Pick up some changes #330
Merged
Pick up some changes #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix extract css related link * change to secureable schema # Conflicts: # src/v2/guide/deployment.md
As someone new to Vuejs, it took me a few extra seconds to grok the expanded code block for when `v-model` is used with a component. My mind was somehow trying to relate the 3rd block of code with the 2nd block, instead of the 1st. (https://vuejs.org/v2/guide/components.html#Form-Input-Components-using-Custom-Events). I suggest re-wording it to make it a bit more obvious. # Conflicts: # src/v2/guide/components.md
# Conflicts: # themes/vue/layout/post.ejs
Remove extra comma in the Object Syntax example for computed properties
kazupon
requested changes
Sep 8, 2017
src/v2/guide/deployment.md
Outdated
| @@ -78,9 +78,9 @@ Webpack を使用している場合、JavaScript と テンプレートの分離 | |||
|
|
|||
| それぞれのビルドツールのドキュメントを参照してください: | |||
|
|
|||
| - [Webpack + vue-loader](http://vue-loader.vuejs.org/en/configurations/extract-css.html) (`vue-cli` の webpack テンプレートは既に設定済み) | |||
| - [Webpack + vue-loader](https://vue-loader.vuejs.org/en/configurations/extract-css.html) (`vue-cli` の webpack テンプレートは既に設定済み) | |||
There was a problem hiding this comment.
日本語向けなので、下記日本語訳のvue-loaderのリンク先にしましょう！
https://vue-loader.vuejs.org/ja/configurations/extract-css.html
There was a problem hiding this comment.
ありがとうございます！修正しました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from
vuejs/v2.vuejs.org@e51d0ef
vuejs/v2.vuejs.org@2e4d65f
vuejs/v2.vuejs.org@7636c34
vuejs/v2.vuejs.org@19d8fa7
vuejs/v2.vuejs.org@60731ef