10000 PEP440 normalization code structure suggestions by aignas · Pull Request #1 · vonschultz/rules_python · GitHub
[go: up one dir, main page]
Skip to content

PEP440 normalization code structure suggestions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 28, 2023
Merged

PEP440 normalization code structure suggestions #1

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0705d10
refactor: move normalization into a separate file
aignas Aug 27, 2023
d014bc6
refactor: move helper nested defs to be private defs
aignas Aug 27, 2023
1c79b26
refactor: move version and contexts to a self struct
aignas Aug 27, 2023
a9d06f0
refactor: create a normalize function
aignas Aug 27, 2023
df2f124
refactor: move open_context to be a method on the normalizer struct
aignas Aug 27, 2023
1355341
refactor: move more predicates outside
aignas Aug 27, 2023
0a93c81
refactor: move close_context to self.close_context
aignas Aug 27, 2023
9ed69be
refactor: move accept to self.accept
aignas Aug 27, 2023
7f80890
refactor: move all of the methods to be functions instead
aignas Aug 27, 2023
f4be867
refactor: restrict usage of contexts to the internal parser functions
aignas Aug 27, 2023
efc66d4
refactor: move accept back to be a regular function
aignas Aug 27, 2023
d2f6b74
refactor: rename context -> ctx
aignas Aug 27, 2023
03f6348
refactor: rename tail -> context
aignas Aug 27, 2023
dca427c
refactor: drop parameters from open_context
aignas Aug 27, 2023
fcfff02
refactor: rename pop -> pop_context
aignas Aug 27, 2023
ac27a62
refactor: rename version -> input in the parser
aignas Aug 27, 2023
872a648
refactor: rename pop_context -> discard
aignas Aug 27, 2023
4237439
refactor: rename close_context -> accept
aignas Aug 27, 2023
1076fd7
refactor: use parser.discard and parser.accept methods
aignas Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: move all of the methods to be functions instead
  • Loading branch information
@aignas
aignas committed Aug 27, 2023
commit 7f80890767e01aa6731f7a58269854e05f002424
Loading
0