8000 PEP440 normalization code structure suggestions by aignas · Pull Request #1 · vonschultz/rules_python · GitHub
[go: up one dir, main page]
Skip to content

PEP440 normalization code structure suggestions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 28, 2023
Merged

PEP440 normalization code structure suggestions #1

merged 19 commits into from
Aug 28, 2023

Conversation

aignas
Copy link
@aignas aignas commented Aug 27, 2023

Right now these do not pass buildifier documentation warnings, but they do pass tests. Feel free to merge it into your branch and make further edits.

aignas added 19 commits August 27, 2023 10:00
@aignas
refactor: move normalization into a separate file
0705d10
@aignas
refactor: move helper nested defs to be private defs
d014bc6
@aignas
refactor: move version and contexts to a self struct
1c79b26
@aignas
refactor: create a normalize function
a9d06f0
@aignas
refactor: move open_context to be a method on the normalizer struct
df2f124
@aignas
refactor: move more predicates outside
1355341
@aignas
refactor: move close_context to self.close_context
0a93c81
@aignas
refactor: move accept to self.accept
9ed69be
@aignas
refactor: move all of the methods to be functions instead
7f80890
@aignas
refactor: restrict usage of contexts to the internal parser functions
f4be867
@aignas
refactor: move accept back to be a regular function
efc66d4
@aignas
refactor: rename context -> ctx
d2f6b74
@aignas
refactor: rename tail -> context
03f6348
@aignas
refactor: drop parameters from open_context
dca427c
@aignas
refactor: rename pop -> pop_context
fcfff02
@aignas
refactor: rename version -> input in the parser
ac27a62
@aignas
refactor: rename pop_context -> discard
872a648
@aignas
refactor: rename close_context -> accept
4237439
@aignas
refactor: use parser.discard and parser.accept methods
1076fd7
@aignas aignas mentioned this pull request Aug 27, 2023
8617
Merged
@vonschultz vonschultz merged commit 6816bd4 into vonschultz:pep440 Aug 28, 2023
@aignas aignas deleted the pep440-suggestions branch May 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonschultz vonschultz vonschultz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aignas @vonschultz
0