8000 Allow methodcall and new to access interface arrays by nbstrike · Pull Request #5973 · verilator/verilator · GitHub
[go: up one dir, main page]
Skip to content

Allow methodcall and new to access interface arrays #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2025
Merged

Allow methodcall and new to access interface arrays #5973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d8edd0
Allow methodcall and new to access interface array. LHS of array assi…
nbstrike Mar 22, 2025
da092dc
Merge branch 'master' into iface-assign-error
nbstrike May 10, 2025
7ac1fa6
resolve test merge conflict for t_interface_dearray_bad
nbstrike May 10, 2025
0f6378e
Move V3Inst to handle AstArraySel as a visitor.
nbstrike May 10, 2025
2e56ce4
Apply 'make format'
May 11, 2025
ab18b2f
Fix loop const signedness.
nbstrike May 11, 2025
984df9a
Apply 'make format'
May 11, 2025
6f6ffdc
Assigning an interface to an interface should be unsupported, not ill…
nbstrike May 15, 2025
733d58d
Fix test output
nbstrike May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 47 additions & 51 deletions src/V3Inst.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,33 +466,32 @@ class InstDeVisitor final : public VNVisitor {
VL_DO_DANGLING(pushDeletep(nodep), nodep);
}
}

void visit(AstNodeAssign* nodep) override {
if (AstArraySel* const arrselp = VN_CAST(nodep->rhsp(), ArraySel)) {
// handle single element selection from RHS array
if (const AstUnpackArrayDType* const arrp
= VN_CAST(arrselp->fromp()->dtypep()->skipRefp(), UnpackArrayDType)) {
if (!VN_IS(arrp->subDTypep()->skipRefp(), IfaceRefDType)) return;
if (VN_AS(arrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual()) return;
V3Const::constifyParamsEdit(arrselp->bitp());
const AstConst* const constp = VN_CAST(arrselp->bitp(), Const);
if (!constp) {
arrselp->bitp()->v3warn(E_UNSUPPORTED,
"Non-constant index in RHS interface array selection");
return;
}
const string index = AstNode::encodeNumber(constp->toSInt());
const AstVarRef* const varrefp = VN_CAST(arrselp->fromp(), VarRef);
UASSERT_OBJ(varrefp, arrselp, "No interface varref under array");
AstVarXRef* const newp = new AstVarXRef{
nodep->fileline(), varrefp->name() + "__BRA__" + index + "__KET__", "",
VAccess::READ};
newp->dtypep(arrp->subDTypep());
newp->classOrPackagep(varrefp->classOrPackagep());
arrselp->addNextHere(newp);
VL_DO_DANGLING(arrselp->unlinkFrBack()->deleteTree(), arrselp);
void visit(AstArraySel* nodep) override {
if (const AstUnpackArrayDType* const arrp
= VN_CAST(nodep->fromp()->dtypep()->skipRefp(), UnpackArrayDType)) {
if (!VN_IS(arrp->subDTypep()->skipRefp(), IfaceRefDType)) return;
if (VN_AS(arrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual()) return;
V3Const::constifyParamsEdit(nodep->bitp());
const AstConst* const constp = VN_CAST(nodep->bitp(), Const);
if (!constp) {
nodep->bitp()->v3warn(E_UNSUPPORTED,
"Non-constant index in RHS interface array selection");
return;
}
} else if (AstSliceSel* const arrslicep = VN_CAST(nodep->rhsp(), SliceSel)) {
const string index = AstNode::encodeNumber(constp->toSInt());
const AstVarRef* const varrefp = VN_CAST(nodep->fromp(), VarRef);
UASSERT_OBJ(varrefp, nodep, "No interface varref under array");
AstVarXRef* const newp = new AstVarXRef{
nodep->fileline(), varrefp->name() + "__BRA__" + index + "__KET__", "",
VAccess::READ};
newp->dtypep(arrp->subDTypep());
newp->classOrPackagep(varrefp->classOrPackagep());
nodep->addNextHere(newp);
VL_DO_DANGLING(pushDeletep(nodep->unlinkFrBack()), nodep);
}
}
void visit(AstNodeAssign* nodep) override {
if (AstSliceSel* const arrslicep = VN_CAST(nodep->rhsp(), SliceSel)) {
if (const AstUnpackArrayDType* const arrp
= VN_CAST(arrslicep->fromp()->dtypep(), UnpackArrayDType)) {
if (!VN_IS(arrp->subDTypep(), IfaceRefDType)) return;
Expand All @@ -501,15 +500,20 @@ class InstDeVisitor final : public VNVisitor {
return;
}
} else {
if (const AstUnpackArrayDType* const lhsarrp
= VN_CAST(nodep->lhsp()->dtypep()->skipRefp(), UnpackArrayDType)) {
if (const AstUnpackArrayDType* const rhsarrp
= VN_CAST(nodep->rhsp()->dtypep()->skipRefp(), UnpackArrayDType)) {
if (const AstUnpackArrayDType* const rhsarrp
= VN_CAST(nodep->rhsp()->dtypep()->skipRefp(), UnpackArrayDType)) {
if (const AstUnpackArrayDType* const lhsarrp
= VN_CAST(nodep->lhsp()->dtypep()->skipRefp(), UnpackArrayDType)) {
// copy between arrays
if (!VN_IS(lhsarrp->subDTypep()->skipRefp(), IfaceRefDType)) return;
if (!VN_IS(rhsarrp->subDTypep()->skipRefp(), IfaceRefDType)) return;
if (VN_AS(rhsarrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual())
return;
if (!VN_AS(lhsarrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual()) {
nodep->v3warn(E_UNSUPPORTED, "Unexpected target of interface assignment ["
<< rhsarrp->prettyDTypeNameQ() << "]");
return;
}
if (lhsarrp->elementsConst() != rhsarrp->elementsConst()) {
nodep->v3warn(E_UNSUPPORTED,
"Array size mismatch in interface assignment");
Expand All @@ -519,30 +523,17 @@ class InstDeVisitor final : public VNVisitor {
const string index = AstNode::encodeNumber(i);
AstNodeExpr* lhsp = nullptr;
if (AstVarRef* const varrefp = VN_CAST(nodep->lhsp(), VarRef)) {
if (VN_AS(lhsarrp->subDTypep()->skipRefp(), IfaceRefDType)
->isVirtual()) {
AstVarRef* const newvarp = varrefp->cloneTree(false);
AstArraySel* newarrselp = new AstArraySel(
nodep->fileline(), newvarp,
new AstConst(nodep->fileline(),
V3Number(nodep->fileline(), 32, i)));
lhsp = newarrselp;
} else {
AstVarXRef* const newvarrefp = new AstVarXRef{
nodep->fileline(),
varrefp->name() + "__BRA__" + index + "__KET__", "",
VAccess::WRITE};
newvarrefp->dtypep(lhsarrp->subDTypep()->skipRefp());
newvarrefp->classOrPackagep(varrefp->classOrPackagep());
lhsp = newvarrefp;
}
AstVarRef* const newvarp = varrefp->cloneTree(false);
AstArraySel* newarrselp = new AstArraySel{
nodep->fileline(), newvarp,
new AstConst{nodep->fileline(), static_cast<uint32_t>(i)}};
lhsp = newarrselp;
} else if (AstMemberSel* const prevselp
= VN_CAST(nodep->lhsp(), MemberSel)) {
AstMemberSel* membselp = prevselp->cloneTree(false);
AstArraySel* newarrselp = new AstArraySel(
AstArraySel* newarrselp = new AstArraySel{
nodep->fileline(), membselp,
new AstConst(nodep->fileline(),
V3Number(nodep->fileline(), 32, i)));
new AstConst{nodep->fileline(), static_cast<uint32_t>(i)}};
lhsp = newarrselp;
} else {
nodep->v3warn(E_UNSUPPORTED,
Expand All @@ -558,15 +549,20 @@ class InstDeVisitor final : public VNVisitor {
AstAssign* const assignp = new AstAssign(nodep->fileline(), lhsp, rhsp);
nodep->addNextHere(assignp);
}
VL_DO_DANGLING(nodep->unlinkFrBack()->deleteTree(), nodep);
VL_DO_DANGLING(pushDeletep(nodep->unlinkFrBack()), nodep);
return;
}
}
}
iterateChildren(nodep);
}

//--------------------
void visit(AstNodeExpr*) override {} // Accelerate
void visit(AstNode* nodep) override { iterateChildren(nodep); }
void visit(AstNew* nodep) override { iterateChildren(nodep); }
void visit(AstMethodCall* nodep) override { iterateChildren(nodep); }
void visit(AstArg* nodep) override { iterateChildren(nodep); }

public:
// CONSTRUCTORS
Expand Down
15 changes: 12 additions & 3 deletions test_regress/t/t_interface_dearray.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,34 @@ endinterface
typedef virtual A a_t;
typedef a_t a_array_t[6];

class B;
function new(virtual A va);
endfunction
endclass

class C;
a_array_t vif;

function void set(int index, a_t iface);
vif[index] = iface;
endfunction
endclass

module tb_top();
A a[6](), b[6]();
A a[6]();
C c, d, e;
a_array_t g;

initial begin
static a_t aa = a[0];

b = a;
B b = new(a[0]);

c = new();
c.vif = a;

d = new();
d.vif[0] = a[0];
d.set(0, a[0]);
d.vif[1] = a[1];

g[0] = a[0];
Expand Down
28 changes: 16 additions & 12 deletions test_regress/t/t_interface_dearray_bad.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:25:13: Array size mismatch in interface assignment
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:23:9: Unexpected target of interface assignment ['IFACEREFDTYPE$[0:5]']
: ... note: In instance 'tb_top'
23 | a = f;
| ^
... For error description see https://verilator.org/warn/UNSUPPORTED?v=latest
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:26:13: Array size mismatch in interface assignment
: ... note: In instance 'tb_top'
25 | c.vif = b;
26 | c.vif = b;
| ^
... For error description see https://verilator.org/warn/UNSUPPORTED?v=latest
%Error: t/t_interface_dearray_bad.v:30:23: Expecting expression to be constant, but variable isn't const: 'i'
%Error: t/t_interface_dearray_bad.v:31:23: Expecting expression to be constant, but variable isn't const: 'i'
: ... note: In instance 'tb_top'
30 | d.vif[i] = a[i];
31 | d.vif[i] = a[i];
| ^
... See the manual at https://verilator.org/verilator_doc.html?v=latest for more assistance.
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:30:23: Non-constant index in RHS interface array selection
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:31:23: Non-constant index in RHS interface array selection
: ... note: In instance 'tb_top'
30 | d.vif[i] = a[i];
31 | d.vif[i] = a[i];
| ^
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:34:16: Interface slices unsupported
%Error-UNSUPPORTED: t/t_interface_dearray_bad.v:35:16: Interface slices unsupported
: ... note: In instance 'tb_top'
34 | e.vif = b[0:5];
35 | e.vif = b[0:5];
| ^
%Error: Internal Error: t/t_interface_dearray_bad.v:25:15: ../V3Broken.cpp:#: Broken link in node (or something without maybePointedTo): 'm_varp && !m_varp->brokeExists()' @ ./V3Ast__gen_impl.h:#
%Error: Internal Error: t/t_interface_dearray_bad.v:23:11: ../V3Broken.cpp:#: Broken link in node (or something without maybePointedTo): 'm_varp && !m_varp->brokeExists()' @ ./V3Ast__gen_impl.h:#
: ... note: In instance 'tb_top'
25 | c.vif = b;
| ^
23 | a = f;
| ^
... This fatal error may be caused by the earlier error(s); resolve those first.
3 changes: 2 additions & 1 deletion test_regress/t/t_interface_dearray_bad.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ class C;
endclass

module tb_top();
A a[6](), b[7]();
A a[6](), b[7](), f[6]();
C c, d, e;
a_array_t g;

initial begin
a = f;

c = new();
c.vif = b;
Expand Down
0