8000 Allow methodcall and new to access interface arrays by nbstrike · Pull Request #5973 · verilator/verilator · GitHub
[go: up one dir, main page]

Skip to content

Allow methodcall and new to access interface arrays #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2025

Conversation

nbstrike
Copy link
Contributor
@nbstrike nbstrike commented May 2, 2025

Handle de-array case so that new and methods can access interfaces from an array.

…gnment should not be a non-virtual interface.
Copy link
Member
@wsnyder wsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please resolve the test conflict.

@wsnyder
Copy link
Member
wsnyder commented May 11, 2025

Let me know when ready for another review - first click "resolved" on above, remove commented-out code, and do a "make format" please.

@nbstrike
Copy link
Contributor Author

This should be ready for another review, I'm slightly surprised that 'make format' has apparently run itself!

Copy link
Member
@wsnyder wsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoformatter is cancelling the regression run, so you need to run it on your side and push.

@nbstrike
Copy link
Contributor Author

Please can you review again, I think comments to date should be resolved.

@wsnyder wsnyder merged commit 8a8f041 into verilator:master May 30, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0