8000 chore: fix `prefer-node-protocol` lint failure on main by abrahamguo · Pull Request #9819 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

chore: fix prefer-node-protocol lint failure on main #9819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

#9711 added a lint failure on main because of my lint rule being enabled (prefer-node-protocol)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link
netlify bot commented Aug 19, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 64f8812
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66c332786af69b00072b425c
😎 Deploy Preview https://deploy-preview-9819--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Speedy ⚡ 😄

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 19, 2024
Copy link
nx-cloud bot commented Aug 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64f8812. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 05d1ddb into typescript-eslint:main Aug 19, 2024
57 of 58 checks passed
Copy link
codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (8087d17) to head (64f8812).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9819      +/-   ##
==========================================
- Coverage   88.04%   88.02%   -0.02%     
==========================================
  Files         403      405       +2     
  Lines       13800    13870      +70     
  Branches     4026     4052      +26     
==========================================
+ Hits        12150    12209      +59     
- Misses       1342     1352      +10     
- Partials      308      309       +1     
Flag Coverage Δ
unittest 88.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0