-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: fix prefer-node-protocol
lint failure on main
#9819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix prefer-node-protocol
lint failure on main
#9819
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Speedy ⚡ 😄
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 64f8812. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
05d1ddb
into
typescript-eslint:main
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9819 +/- ##
==========================================
- Coverage 88.04% 88.02% -0.02%
==========================================
Files 403 405 +2
Lines 13800 13870 +70
Branches 4026 4052 +26
==========================================
+ Hits 12150 12209 +59
- Misses 1342 1352 +10
- Partials 308 309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR Checklist
Overview
#9711 added a lint failure on main because of my lint rule being enabled (
prefer-node-protocol
)