8000 test(type-utils): add tests for containsAllTypesByName by y-hsgw · Pull Request #9711 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

test(type-utils): add tests for containsAllTypesByName #9711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

test(type-utils): add tests for containsAllTypesByName #9711

merged 2 commits into from
Aug 19, 2024

Conversation

y-hsgw
Copy link
Contributor
@y-hsgw y-hsgw commented Aug 3, 2024 •
edited
Loading

PR Checklist

Overview

Added test case for containsAllTypesByName function.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Aug 3, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5fbcce4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66adcdba87a7fa00087218e1
😎 Deploy Preview https://deploy-preview-9711--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Aug 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5fbcce4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link
codecov bot commented Aug 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (2761ca8) to head (5fbcce4).
Report is 52 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9711      +/-   ##
==========================================
+ Coverage   88.07%   88.18%   +0.10%     
==========================================
  Files         402      402              
  Lines       13691    13691              
  Branches     3982     3982              
==========================================
+ Hits        12058    12073      +15     
+ Misses       1324     1308      -16     
- Partials      309      310       +1
Flag Coverage Δ
unittest 88.18% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David Tennant as Crowley saying "You've definitely passed the test"

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit fd57da9 into typescript-eslint:main Aug 19, 2024
60 of 62 checks passed
@abrahamguo abrahamguo mentioned this pull request Aug 19, 2024
Merged
3 tasks
@y-hsgw y-hsgw deleted the test/containsAllTypesByName branch August 19, 2024 11:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-hsgw @JoshuaKGoldberg
0