8000 fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types by Zamiell · Pull Request #8063 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types #8063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de7a2db
fix: bug
Zamiell Sep 18, 2023
94dc3ac
Merge branch 'main' into enum-comparison-rule-fix
Zamiell Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eslint-plugin/src/rules/no-unsafe-enum-comparison.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
*/
function typeViolates(leftTypeParts: ts.Type[], right: ts.Type): boolean {
const leftValueKinds = new Set(leftTypeParts.map(getEnumValueType));

return (
(leftValueKinds.has(ts.TypeFlags.Number) &&
tsutils.isTypeFlagSet(
Expand Down
11 changes: 11 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unsafe-enum-comparison.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,5 +1080,16 @@ ruleTester.run('strict-enums-comparison', rule, {
},
],
},
{
code: `
enum Fruit {
Apple,
}
declare const foo: number & {};
if (foo === Fruit.Apple) {
}
`,
errors: [{ messageId: 'mismatched' }],
},
],
});
0