8000 fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types by Zamiell · Pull Request #8063 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types #8063

wants to merge 2 commits into from

Conversation

Zamiell
Copy link
Contributor
@Zamiell Zamiell commented Dec 13, 2023

PR Checklist

Overview

this should be a pretty straightforward PR

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 94dc3ac
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6579be8dd124390008b65aeb
😎 Deploy Preview https://deploy-preview-8063--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zamiell Zamiell changed the title fix: bug fix(eslint-plugin): [no-unsafe-enum-comparison] false positive with enums in a union with branded types Dec 13, 2023
@JoshuaKGoldberg
Copy link
Member

👋 ping @Zamiell, is this ready for review?

@JoshuaKGoldberg
Copy link
Member
JoshuaKGoldberg commented Mar 17, 2024 •
edited
Loading

Closing this PR as it's been stale for a few months without activity. Feel free to reopen @Zamiell if you have time - but no worries if not! If anybody wants to drive it forward, please do post your own PR - and if you use this as a start, consider adding a co-authored-by attribution at the end of your PR description. Thanks! 😊

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
@Zamiell Zamiell deleted the enum-comparison-rule-fix branch August 11, 2024 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-enum-comparison] false positive with enums in a union with branded types
2 participants
@Zamiell @JoshuaKGoldberg
0