8000 docs: Update Local_Development.mdx by Zamiell · Pull Request #7395 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]

Skip to content

docs: Update Local_Development.mdx #7395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

docs: Update Local_Development.mdx #7395

wants to merge 2 commits into from

Conversation

Zamiell
Copy link
Contributor
@Zamiell Zamiell commented Aug 1, 2023

PR Checklist

Overview

Making docs more explicit. Future PRs should add better error messages to make reading the docs unnecessary.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
netlify bot commented Aug 1, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a27b5ae
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64c924ea179dbb00080aac86
😎 Deploy Preview https://deploy-preview-7395--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor
@kemilbeltre kemilbeltre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update!

@nx-cloud
Copy link
nx-cloud bot commented Aug 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a27b5ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

Comment on lines +89 to +93
After cloning the repository, run the following steps to install and build the website:

```sh
yarn install # To ensure that the dependencies are installed.
yarn build # This builds all the packages except for `website-eslint` and `website`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After cloning the repository, run the following steps to install and build the website:
```sh
yarn install # To ensure that the dependencies are installed.
yarn build # This builds all the packages except for `website-eslint` and `website`.
Before running `yarn start` you have to execute the following commands to build the necessary packages:
```sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the existing text better as it doesn't assume that someone has read a disparate section of the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, you can't skip the setup.

Copy link
Contributor Author
@Zamiell Zamiell Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can - you can be directly linked to this section or be warped to this section from the Algolia search bar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we should just say "remember to run the setup steps at the top of the page".

Copy link
Member
@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord conversations are not a reliable source of change requests, even for docs 😄. Closing this because it's debatable whether the changes are useful. And the root of the issue is that yarn build doesn't build website-eslint.

Thanks though!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
@Zamiell Zamiell deleted the patch-3 branch September 17, 2023 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0