-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: Update Local_Development.mdx #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @Zamiell! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update!
After cloning the repository, run the following steps to install and build the website: | ||
|
||
```sh | ||
yarn install # To ensure that the dependencies are installed. | ||
yarn build # This builds all the packages except for `website-eslint` and `website`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After cloning the repository, run the following steps to install and build the website: | |
```sh | |
yarn install # To ensure that the dependencies are installed. | |
yarn build # This builds all the packages except for `website-eslint` and `website`. | |
Before running `yarn start` you have to execute the following commands to build the necessary packages: | |
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the existing text better as it doesn't assume that someone has read a disparate section of the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, you can't skip the setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can - you can be directly linked to this section or be warped to this section from the Algolia search bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, we should just say "remember to run the setup steps at the top of the page".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discord conversations are not a reliable source of change requests, even for docs 😄. Closing this because it's debatable whether the changes are useful. And the root of the issue is that yarn build
doesn't build website-eslint
.
Thanks though!
PR Checklist
Overview
Making docs more explicit. Future PRs should add better error messages to make reading the docs unnecessary.