8000 Repo: yarn build doesn't build website-eslint · Issue #7417 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: yarn build doesn't build website-eslint #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 5, 2023 · 1 comment · Fixed by #7638
Closed

Repo: yarn build doesn't build website-eslint #7417

JoshuaKGoldberg opened this issue Aug 5, 2023 · 1 comment · Fixed by #7638
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member
JoshuaKGoldberg commented Aug 5, 2023 •
edited
Loading

Suggestion

Setting up a new repository locally in theory requires just yarn as pre-work before yarn start. In theory yarn should both install and run a full build (it calls to yarn build). But yarn build specifically excludes the website-eslint package:

typescript-eslint/package.json

Line 26 in 18f8d74

"build": "nx run-many --target=build --parallel --exclude website --exclude website-eslint",

That means if you yarn start after just yarn, the website gives a complaint like:

[ERROR] Error: Cannot find module '/Users/josh/repos/typescript-eslint-upstream/node_modules/@typescript-eslint/website-eslint/dist/index.js'

Is there a reason yarn build excludes website-eslint?

@Zamiell's #7395 touched on this too.
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Aug 5, 2023
@bradzacher
Copy link
Member

It's excluded because it's slow and not used for anything except the website!

Instead of adding it to the base build - IMO we should add it to the website build somehow. Idk if we can use node on or something to pair it with yarn start or something?

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Sep 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 12, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(website): have start depend on website-eslint:build JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher
0