chore: skip website tests on PRs from forks #7296
Conversation
|
Thanks for the PR, @kachick! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| # The NETLIFY_TOKEN secret will not be available on PRs from forks | ||
| if: (github.event_name == 'push' && github.ref_name == 'main') || (github.event.pull_request.head.repo.full_name == github.repository) |
There was a problem hiding this comment.
This change does not block PRs in a fork to the same fork.
If we really need to skip all PRs in forks, this may be following
| # The NETLIFY_TOKEN secret will not be available on PRs from forks | |
| if: (github.event_name == 'push' && github.ref_name == 'main') || (github.event.pull_request.head.repo.full_name == github.repository) | |
| # The NETLIFY_TOKEN secret will not be available on forks | |
| if: (github.event_name == 'push' && github.ref_name == 'main') || (github.event.pull_request.head.repo.full_name == 'typescript-eslint/typescript-eslint') |
| # The NETLIFY_TOKEN secret will not be available on forks | ||
| if: github.repository_owner == 'typescript-eslint' | ||
| # The NETLIFY_TOKEN secret will not be available on PRs from forks | ||
| if: (github.event_name == 'push' && github.ref_name == 'main') || (github.event.pull_request.head.repo.full_name == github.repository) |
There was a problem hiding this comment.
I have a question, merge_group should trigger this test? Then it may be following
| if: (github.event_name == 'push' && github.ref_name == 'main') || (github.event.pull_request.head.repo.full_name == github.repository) | |
| if: contains(fromJSON('["push", "merge_group"]'), github.event_name) || (github.event.pull_request.head.repo.full_name == github.repository) |
There was a problem hiding this comment.
We don't use merge queues. I don't think test triggers need to account for them.
There was a problem hiding this comment.
Thanks for sharing the direction! I just had confused with the trigger in here 🙇♂️
|
cc @rubiesonthesky from #7247 with a different approach |
|
Thank you, #7247 seems to be aiming for a more polite way, so I close this PR. |
PR Checklist
Overview