8000 Repo: CI / Website tests (pull_request) fails on PRs from forks · Issue #7168 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: CI / Website tests (pull_request) fails on PRs from forks #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Jul 6, 2023 · 2 comments · Fixed by #7247
Closed

Repo: CI / Website tests (pull_request) fails on PRs from forks #7168

JoshuaKGoldberg opened this issue Jul 6, 2023 · 2 comments · Fixed by #7247
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Example: #7167 -> https://github.com/typescript-eslint/typescript-eslint/actions/runs/5480558418/jobs/9983914931?pr=7167

/home/runner/work/typescript-eslint/typescript-eslint/node_modules/@actions/core/lib/core.js:106
        throw new Error(`Input required and not supplied: ${name}`);
        ^

@JamesHenry I'm up-to-date from main and still getting this. Are we blocked on anything?
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Jul 6, 2023
@JamesHenry
Copy link
Member

We discussed this on discord and none of us could figure out why the if wasn't causing it to skip the task on forks as intended...

We can't hit the Netlify API without an auth token, and we can't use the auth token without it being a secret naturally, so we are kind of stuck with the tests only running on netlify on main and other origin branches

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jul 13, 2023
@JoshuaKGoldberg
Copy link
Member Author

A few thoughts on approaches:

@rubiesonthesky rubiesonthesky mentioned this issue Jul 17, 2023
Merged
3 tasks
This was referenced Jul 22, 2023
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
2 participants
@JamesHenry @JoshuaKGoldberg
0