8000 docs: re-ran generate-sponsors and expanded homepage listing by JoshuaKGoldberg · Pull Request #4371 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

docs: re-ran generate-sponsors and expanded homepage listing #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2022
Merged

docs: re-ran generate-sponsors and expanded homepage listing #4371

merged 2 commits into from
Jan 11, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

  • Adds explicit h3s with paragraph descriptions for each of the tiers
  • Mostly clarifies the terminology: "financial contributor" is split into "sponsors" and "supporters".
  • Increases the size of sponsors and gives them a text title
500px width 1000px width 1500px width
Mobile screenshot showing a narrow column of sections Tablet screenshot showing a wide column sections Desktop screenshot showing side-by-side sections

8000
@nx-cloud
Copy link
nx-cloud bot commented Dec 30, 2021 •
edited
Loading

☁️ Nx Cloud Report

CI ran the following commands for commit c52a754. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link
netlify bot commented Dec 30, 2021 •
edited
Loading
8000

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: c52a754

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61ce27a112fb530008c37823

😎 Browse the preview: https://deploy-preview-4371--typescript-eslint.netlify.app

JoshuaKGoldberg
JoshuaKGoldberg commented Dec 30, 2021
View reviewed changes
tools/generate-sponsors.ts
@@ -24,6 +25,10 @@ const graphqlQuery = `{
}
}`;

const excludedIds = new Set([
'53kzxy4v-07wlr6mr-o9epmj9n-o8agdbe5', // Josh Goldberg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind being here, but the list of contributors overflows unless we remove one... 😄

Also, my GraphQL competency is pretty weak and I couldn't figure out the right : not; otherwise I'd embed this in that query...

8000 Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the list of contributors overflows unless we remove one

Wait - won't this be a problem in future if we have more sponsors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It's not the end of the world, just a single square on a next line. I can always add myself back 😄

@codecov
Copy link
codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #4371 (2ad2f52) into main (4bb55a2) will increase coverage by 0.38%.
The diff coverage is 76.92%.

❗ Current head 2ad2f52 differs from pull request most recent head c52a754. Consider uploading reports for the commit c52a754 to get more accurate results

@@            Coverage Diff             @@
##             main    #4371      +/-   ##
==========================================
+ Coverage   93.88%   94.26%   +0.38%     
==========================================
  Files         297      169     -128     
  Lines       11193     9440    -1753     
  Branches     3253     2940     -313     
==========================================
- Hits        10509     8899    -1610     
+ Misses        416      321      -95     
+ Partials      268      220      -48
Flag Coverage Δ
unittest 94.26% <76.92%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.30% <ø> (ø)
...ackages/eslint-plugin/src/util/getWrappingFixer.ts 100.00% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 90.36% <57.14%> (-3.15%) ⬇️
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.19% <100.00%> (-0.03%) ⬇️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100.00% <100.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <100.00%> (ø)
packages/eslint-plugin/src/util/misc.ts 93.33% <100.00%> (ø)
.../experimental-utils/src/eslint-utils/nullThrows.ts
packages/type-utils/src/isTypeReadonly.ts
packages/type-utils/src/propertyTypes.ts
... and 124 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 30, 2021 21:46
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Dec 31, 2021
@bradzacher bradzacher merged commit e60b638 into typescript-eslint:main Jan 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the sponsors-expanded branch March 1, 2022 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate missing "financial contributors" section contents
3 participants
@JoshuaKGoldberg @armano2 @bradzacher
0