8000 Investigate missing "financial contributors" section contents · Issue #4370 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Investigate missing "financial contributors" section contents #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Dec 30, 2021 · 5 comments · Fixed by #4371, #4372 or #4546
Closed

Investigate missing "financial contributors" section contents #4370

JoshuaKGoldberg opened this issue Dec 30, 2021 · 5 comments · Fixed by #4371, #4372 or #4546
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working documentation Documentation ("docs") that needs adding/updating

Comments

@JoshuaKGoldberg
Copy link
Member
JoshuaKGoldberg commented Dec 30, 2021 •
edited
Loading

This was mentioned somewhere, I want to say in Slack?

We should have someone look at the Financial Contributors section on the homepage and make sure it includes all financial contributors.

Edit: it's because the data is sourced from

typescript-eslint/packages/website/data/sponsors.json

Line 1 in 31d9c8e

[
. We should update that automatically and/or have it be realtime.
@JoshuaKGoldberg JoshuaKGoldberg moved this from Todo to In Progress in Documentation Dec 30, 2021
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 30, 2021
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working documentation Documentation ("docs") that needs adding/updating labels Dec 30, 2021
@JoshuaKGoldberg
Copy link
Member Author

Well, OpenCollective lists more than a dozen recurring supporters:

Screenshot of multiple recurring sponsor sections on OpenCollective

...but the website right now only lists nine, including one with initials instead of a photo:

Screenshot of the website with nine sponsors

Something fishy is happening!

@JoshuaKGoldberg
Copy link
Member Author

Oh, it's all sourced from https://github.com/typescript-eslint/typescript-eslint/blob/31d9c8e5f15941a89a770bf32ddb9d2a70601c98/packages/website/data/sponsors.json.

@bradzacher
Copy link
Member

We might want to have a job which periodically updates this file? (Same with the contributors file)

That way our builds don't depend on any web requests. Or we could just query for them from the website live? Depends if we want to add another 3rd party query dependency and risk not showing them if something goes down.

@JoshuaKGoldberg
Copy link
Member Author

Yeah my instinct is to MVP it with a cron job on GHA.

This was referenced Dec 30, 2021
Merged
Merged
@JoshuaKGoldberg JoshuaKGoldberg moved this from In Progress to In Review in Documentation Dec 30, 2021
Repository owner moved this from In Review to Done in Documentation Jan 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
@JoshuaKGoldberg
Copy link
Member Author

Re-opening for #4546 🥳

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Documentation
Status: Done
Milestone
No milestone
2 participants
@JoshuaKGoldberg @bradzacher
0