8000 fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to suggestion by kirkwaiblinger · Pull Request #11081 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to suggestion #11081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to suggestion #11081

merged 2 commits into from
Apr 22, 2025

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3fe4d7c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67ffe837c3f2380008a08b5e
😎 Deploy Preview https://deploy-preview-11081--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Apr 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3fe4d7c.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-16 18:02:41 UTC

@codecov Codecov
Copy link
codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (f30a20e) to head (3fe4d7c).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11081   +/-   ##
=======================================
  Coverage   90.82%   90.83%           
=======================================
  Files         497      497           
  Lines       50204    50210    +6     
  Branches     8274     8274           
=======================================
+ Hits        45600    45606    +6     
  Misses       4589     4589           
  Partials       15       15
Flag Coverage Δ
unittest 90.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.57% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ronami
ronami previously approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member
@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 16, 2025
@kirkwaiblinger kirkwaiblinger requested a review from ronami April 16, 2025 17:27
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 16, 2025
@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 16, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0cff7bf into typescript-eslint:main Apr 22, 2025
56 of 59 checks passed
@kirkwaiblinger kirkwaiblinger deleted the nuc-no-autofix branch April 22, 2025 17:53
phaux pushed a commit to phaux/typescript-eslint that referenced this pull request Apr 24, 2025
@kirkwaiblinger @phaux
fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to sugge…
b93a1fb 
…stion (typescript-eslint#11081)

* downgrade nuc fix to suggestion

* feedback
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@ronami ronami ronami approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-condition] False error on uninitialized variable
3 participants
@kirkwaiblinger @JoshuaKGoldberg @ronami
0