8000 fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to sugge… · phaux/typescript-eslint@b93a1fb · GitHub
[go: up one dir, main page]

Skip to content

Commit b93a1fb

Browse files
kirkwaiblingerphaux
authored andcommitted
fix(eslint-plugin): [no-unnecessary-condition] downgrade fix to suggestion (typescript-eslint#11081)
* downgrade nuc fix to suggestion * feedback
1 parent 93d7e8c commit b93a1fb

File tree

2 files changed

+558
-116
lines changed

2 files changed

+558
-116
lines changed

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ export type MessageId =
152152
| 'neverOptionalChain'
153153
| 'noOverlapBooleanExpression'
154154
| 'noStrictNullCheck'
155+
| 'suggestRemoveOptionalChain'
155156
| 'typeGuardAlreadyIsType';
156157

157158
export default createRule<Options, MessageId>({
@@ -164,7 +165,7 @@ export default createRule<Options, MessageId>({
164165
recommended: 'strict',
165166
requiresTypeChecking: true,
166167
},
167-
fixable: 'code',
168+
hasSuggestions: true,
168169
messages: {
169170
alwaysFalsy: 'Unnecessary conditional, value is always falsy.',
170171
alwaysFalsyFunc:
@@ -184,6 +185,7 @@ export default createRule<Options, MessageId>({
184185
'Unnecessary conditional, the types have no overlap.',
185186
noStrictNullCheck:
186187
'This rule requires the `strictNullChecks` compiler option to be turned on to function correctly.',
188+
suggestRemoveOptionalChain: 'Remove unnecessary optional chain',
187189
typeGuardAlreadyIsType:
188190
'Unnecessary conditional, expression already has the type being checked by the {{typeGuardOrAssertionFunction}}.',
189191
},
@@ -863,9 +865,14 @@ export default createRule<Options, MessageId>({
863865
loc: questionDotOperator.loc,
864866
node,
865867
messageId: 'neverOptionalChain',
866-
fix(fixer) {
867-
return fixer.replaceText(questionDotOperator, fix);
868-
},
868+
suggest: [
869+
{
870+
messageId: 'suggestRemoveOptionalChain',
871+
fix(fixer) {
872+
return fixer.replaceText(questionDotOperator, fix);
873+
},
874+
},
875+
],
869876
});
870877
}
871878

0 commit comments

Comments
 (0)
0