8000
We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I added 3 new test cases that cover the auto-fix of the array-filter rule when used with conditional types. Afterwards I used the hint in the issue and added the typescript AST node "TSConditionalType" to the switch case which made the test case succeed.
I also linked my local typescript-eslint version using my package manager and check that it handles the original case in my code base, which made me open the issue, correctly.
Please feel free to provide feedback, this is my first contribution to typescript-eslint or such a big project at all for that matter.
Sorry, something went wrong.
fix missing parentheses when autofixing array-filter rule with condit…
08a8eff
…ional types
Thanks for the PR, @lunedis!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Thanks again!
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
To edit notification comments on pull requests, go to your Netlify site configuration.
TsConditionalType
View your CI Pipeline Execution ↗ for commit 464854f.
nx run-many --target=build --exclude website --...
nx run-many --target=clean
☁️ Nx Cloud last updated this comment at 2024-12-29 20:03:07 UTC
2024-12-29 20:03:07
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice! Thanks for sending this in! Just requesting minor changes around testing 👍
move conditional array-type tests into standard test block
032d660
All modified and coverable lines are covered by tests ✅
Project coverage is 86.86%. Comparing base (d24a828) to head (464854f). Report is 21 commits behind head on main.
d24a828
464854f
@@ Coverage Diff @@ ## main #10522 +/- ## ========================================== + Coverage 86.78% 86.86% +0.07% ========================================== Files 445 445 Lines 15366 15455 +89 Branches 4475 4507 +32 ========================================== + Hits 13336 13425 +89 Misses 1675 1675 Partials 355 355
86.86% <ø> (+0.07%)
Flags with carried forward coverage won't be shown. Click here to find out more.
97.26% <ø> (ø)
... and 8 files with indirect coverage changes
Everything looks great, just a final touch! 🏆
array-type tests: remove issue comments
Thanks! 🏆
Looks great! Congrats on your first PR to typescript-eslint!! 🙂
3097930
fix(deps): update typescript-eslint monorepo to v8.19.0
04d5198
##### [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30) ##### 🚀 Features - **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106)) ##### 🩹 Fixes - **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536)) - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537)) - **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522)) - **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496)) ##### ❤️ Thank You - Karl Werner - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
fix(eslint-plugin): [array-type] autofix with conditional types needs…
e87cc3c
… parentheses (typescript-eslint#10522) * fix missing parentheses when autofixing array-filter rule with conditional types * move conditional array-type tests into standard test block * array-type tests: remove issue comments
Update typescript-eslint monorepo to v8.19.0
0c79c1b
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.18.2 | 8.19.0 | | npm | @typescript-eslint/parser | 8.18.2 | 8.19.0 | ## [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30) ##### 🚀 Features - **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106)) ##### 🩹 Fixes - **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536)) - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537)) - **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522)) - **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496)) ##### ❤️ Thank You - Karl Werner - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
ronami ronami approved these changes
kirkwaiblinger kirkwaiblinger approved these changes
Successfully merging this pull request may close these issues.