8000 fix(eslint-plugin): [array-type] autofix with conditional types needs parentheses by lunedis · Pull Request #10522 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

fix(eslint-plugin): [array-type] autofix with conditional types needs parentheses #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 30, 2024
Merged

fix(eslint-plugin): [array-type] autofix with conditional types needs parentheses #10522

merged 3 commits into from
Dec 30, 2024

Conversation

lunedis
Copy link
Contributor
@lunedis lunedis commented Dec 19, 2024

PR Checklist

Overview

I added 3 new test cases that cover the auto-fix of the array-filter rule when used with conditional types. Afterwards I used the hint in the issue and added the typescript AST node "TSConditionalType" to the switch case which made the test case succeed.

I also linked my local typescript-eslint version using my package manager and check that it handles the original case in my code base, which made me open the issue, correctly.

Please feel free to provide feedback, this is my first contribution to typescript-eslint or such a big project at all for that matter.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lunedis!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link
netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 464854f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/677111ca7158020008ba8e1b
😎 Deploy Preview https://deploy-preview-10522--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83 (🟢 up 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ronami ronami mentioned this pull request Dec 19, 2024
Closed
3 tasks
@lunedis lunedis changed the title fix(eslint-plugin): [array-filter] autofix with conditional types fix(eslint-plugin): [array-type] autofix with conditional types Dec 19, 2024
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Dec 19, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 464854f.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-29 20:03:07 UTC

ronami
ronami requested changes Dec 20, 2024
View reviewed changes
Copy link
Member
@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice! Thanks for sending this in! Just requesting minor changes around testing 👍

@codecov Codecov
Copy link
codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (d24a828) to head (464854f).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10522      +/-   ##
==========================================
+ Coverage   86.78%   86.86%   +0.07%     
==========================================
  Files         445      445              
  Lines       15366    15455      +89     
  Branches     4475     4507      +32     
==========================================
+ Hits        13336    13425      +89     
  Misses       1675     1675              
  Partials      355      355
Flag Coverage Δ
unittest 86.86% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.26% <ø> (ø)

... and 8 files with indirect coverage changes

@lunedis lunedis requested a review from ronami December 25, 2024 11:41
ronami
ronami requested changes Dec 26, 2024
View reviewed changes
Copy link
Member
@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just a final touch! 🏆

@lunedis lunedis requested a review from ronami December 29, 2024 09:10
ronami
ronami approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member
@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🏆

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 29, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member
@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Congrats on your first PR to typescript-eslint!! 🙂

@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [array-type] autofix with conditional types fix(eslint-plugin): [array-type] autofix with conditional types needs parentheses Dec 29, 2024
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) December 29, 2024 20:02
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3097930 into typescript-eslint:main Dec 30, 2024
65 of 68 checks passed
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Dec 30, 2024
@renovate
fix(deps): update typescript-eslint monorepo to v8.19.0
04d5198 
##### [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30)

##### 🚀 Features

-   **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106))

##### 🩹 Fixes

-   **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536))
-   **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537))
-   **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522))
-   **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496))

##### ❤️ Thank You

-   Karl Werner
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Ronen Amiel
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
OlivierZal pushed a commit to OlivierZal/typescript-eslint that referenced this pull request Dec 30, 2024
@lunedis @OlivierZal
fix(eslint-plugin): [array-type] autofix with conditional types needs…
e87cc3c 
… parentheses (typescript-eslint#10522)

* fix missing parentheses when autofixing array-filter rule with conditional types

* move conditional array-type tests into standard test block

* array-type tests: remove issue comments
@lunedis lunedis deleted the fix/array-filter-autofix-conditional-types branch December 30, 2024 22:20
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 31, 2024
@renovate
Update typescript-eslint monorepo to v8.19.0
0c79c1b 
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.18.2 | 8.19.0 |
| npm        | @typescript-eslint/parser        | 8.18.2 | 8.19.0 |


## [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30)

##### 🚀 Features

-   **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106))

##### 🩹 Fixes

-   **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536))
-   **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537))
-   **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522))
-   **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496))

##### ❤️ Thank You

-   Karl Werner
-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
-   Ronen Amiel
-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)

You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ronami ronami ronami approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: array-type automatic fix changes type logic when used with conditional types
4 participants
@lunedis @ronami @kirkwaiblinger @JoshuaKGoldberg
0