8000 Bug: array-type automatic fix changes type logic when used with conditional types · Issue #10519 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Bug: array-type automatic fix changes type logic when used with conditional types #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
lunedis opened this issue Dec 19, 2024 · 2 comments · Fixed by #10522
Closed
4 tasks done

Bug: array-type automatic fix changes type logic when used with conditional types #10519

lunedis opened this issue Dec 19, 2024 · 2 comments · Fixed by #10522
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@lunedis
Copy link
Contributor
lunedis commented Dec 19, 2024 •
edited
Loading

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=C4TwDgpgBAKuEEYBCEBmB7ATtAvFAgppgIYgA8AzsJgJYB2A5gHwDcAUKJLPAvqsBExQ8VWowDaAXXYd43SACYUGbGRhNhBIqTVQIADwF0AJhSij6DKAH5z1S1ABcUOgFcAtgCNBrWVziKfAKYahp4MHqGECZmFow2dmJWzm5eglLsnNABEAoAovqQAMYCxqGaABQRBkamiQ62cckuHt6YAJQZQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6AQ2mncNqNPRREXAPbRI4MAF8QUoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

type Type1Before = Array<string>;
type Type1After = string[];

type Type2Before<T> = Array<T extends string ? string : number>;
type Type2After<T> = T extends string ? string : number[];
type Type2Expected<T> = (T extends string ? string : number)[];

ESLint Config

{
  "rules": {
    "@typescript-eslint/array-type": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

the automatic fix for

type Type2Before<T> = Array<T extends string ? string : number>;

should result in

type Type2Expected<T> = (T extends string ? string : number)[];

Actual Result

it results in

type Type2After<T> = T extends string ? string : number[];

which is a different type.

Additional Info

No response
@lunedis lunedis added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Dec 19, 2024
@ronami
Copy link
Member
ronami commented Dec 19, 2024 •
edited
Loading

Yes, looks like a bug to me, as the fixer changes the original type to be something it's not 👍

I think the issue is around the typeNeedsParentheses function and is similar to #172.

@ronami ronami added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Dec 19, 2024
@ronami ronami mentioned this issue Dec 19, 2024
Closed
3 tasks
@lunedis lunedis mentioned this issue Dec 19, 2024
Merged
3 tasks
@lunedis
Copy link
Contributor Author
lunedis commented Dec 19, 2024

Haha, I was 6 minutes too slow with my own pull request. But at least we made the same fix!

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jan 7, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
2 participants
@ronami @lunedis
0