8000 test: verify action verification logic consistency with schema by Vampire · Pull Request #261 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

test: verify action verification logic consistency with schema #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2025
Merged

test: verify action verification logic consistency with schema #261

merged 3 commits into from
Feb 2, 2025

Conversation

Vampire
Copy link
Collaborator
@Vampire Vampire commented Jan 31, 2025 •
edited by krzema12
Loading

Part of #253.

@Vampire Graphite App
Copy link
Collaborator Author
Vampire commented Jan 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Vampire
Copy link
Collaborator Author
Vampire commented Jan 31, 2025

Currently there are 31 disagreements.
3 good typings considered bad
20 bad ones considered good
8 bad ones with a disagreement on the problem

@krzema12 krzema12 changed the title test: verify action verification logic consistency with schema (#253) test: verify action verification logic consistency with schema Jan 31, 2025
@krzema12
Copy link
Member

Thanks, I was about to do it today, and even assigned the task to myself, but you beat me 😛

@krzema12
Copy link
Member

Let's just keep this PR open until all discrepancies are addressed, and use it to check what's left.

Fixing the first discrepancy: #264

@krzema12
Copy link
Member

#265

@Vampire
Copy link
Collaborator Author
Vampire commented Jan 31, 2025

Let's just keep this PR open until all discrepancies are addressed, and use it to check what's left.

That was the intention, yes :-)

8000
@krzema12 krzema12 mentioned this pull request Jan 31, 2025
Merged
krzema12 added a commit that referenced this pull request Jan 31, 2025
@krzema12
feat: add extra validation for enums (#266)
6331966 
Part of
#253.

Fixes several failing test cases identified in
#261,
getting us closer to being consistent with the schema.
@krzema12
Copy link
Member

4 failing cases left 😊

@krzema12
Copy link
Member

#267 needs to go first.

@Vampire Vampire force-pushed the vampire/logic-consistency-test branch from edcd54f to 51ebacf Compare February 2, 2025 00:04
@krzema12 krzema12 mentioned this pull request Feb 2, 2025
Merged
krzema12 added a commit that referenced this pull request Feb 2, 2025
@krzema12
test: make non-integer name tests use string that is not a number (#272)
cbd7696 
See the discussion at
#261 (comment)

Since strings that contain integers are a tricky edge case, let's for
now make these test cases use strings that don't represent integers.

CC @Vampire
@Vampire Vampire force-pushed the vampire/logic-consistency-test branch from 51ebacf to 0113d1e Compare February 2, 2025 14:45
krzema12
krzema12 approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member
@krzema12 krzema12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you 🙇

@krzema12 krzema12 merged commit 739e0b8 into main Feb 2, 2025
5 checks passed
@krzema12 krzema12 deleted the vampire/logic-consistency-test branch February 2, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzema12 krzema12 krzema12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vampire @krzema12
0