10000 Sync action's logic and JSON schema · Issue #253 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]

Skip to content
Sync action's logic and JSON schema #253
Closed
@krzema12

Description

@krzema12

We now have github-actions-typing.schema.json. It's not used in any way in the action's logic, for now it's there for some other use cases (e.g. validating typings in the catalog or using it in the IDE).

We'd like to reach a point where both the schema and the action's logic 5DE2 agree with each other in terms of certain typings being valid or not.

To be done:

  • refactor validateTypings to be able to pass the action's manifest and typings as strings, instead of having to use the file system
  • as a part of preparing the test cases, generate action manifests (on the fly) based on some typings
  • add a test that calls validateTypings and uses the "good typings" and the "bad typings" test resources + typings from the catalog and some actions to assert that both mechanisms work the same way
  • it may be necessary to adjust one or the other mechanism - let's discuss case by case
  • once both mechanisms agree, let's consider moving the schema to the root dir of the repo, to increase discoverability

CC @Vampire

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0