8000 Supporting filter_friendly_name by wanjunsli · Pull Request #245 · twilio/twilio-python · GitHub
[go: up one dir, main page]
Skip to content

Supporting filter_friendly_name #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 28, 2016
Merged

Supporting filter_friendly_name #245

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0cace2e
Supporting filter_friendly_name
wanjunsli Jan 12, 2016
3d79b57
Moving imports to beginning of init; removing excess blank lines
wanjunsli Jan 12, 2016
5500cba
Using only filters instead of workflow_rules; added check for friendl…
wanjunsli Jan 18, 2016
3c0b395
fixing indentations, fixed deletion of assertEqual
wanjunsli Jan 18, 2016
ee487ba
removing .iml file
wanjunsli Jan 18, 2016
79daa8d
Reverting all changes; parsing user input for filter_friendly_name an…
wanjunsli Jan 19, 2016
3bb6b3f
Reverting optional param
wanjunsli Jan 19, 2016
11266b0
remove unnecessary import
wanjunsli Jan 19, 2016
5715631
fixed blank line
wanjunsli Jan 19, 2016
cba4bfb
Checking for filter_friendly_name in TaskrouterConfig
wanjunsli Jan 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverting optional param
  • Loading branch information
@wanjunsli
wanjunsli committed Jan 19, 2016
commit 3bb6b3f0be07c1c0911402f9bbe3edb835831f67
2 changes: 1 addition & 1 deletion twilio/task_router/workflow_rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class WorkflowRule:
The name of the filter
"""

def __init__(self, expression, targets, friendly_name=None):
def __init__(self, expression, targets, friendly_name):

self.expression = expression
self.targets = targets
Expand Down
2 changes: 1 addition & 1 deletion twilio/task_router/workflow_ruletarget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class WorkflowRuleTarget:

The timeout before the reservation expires.
"""
def __init__(self, queue, expression, priority=None, timeout=None):
def __init__(self, queue, expression, priority, timeout):

self.queue = queue
self.expression = expression
Expand Down
0