Supporting filter_friendly_name #245
Conversation
| return str({ | ||
| 'workflow_rules': self.workflow_rules, | ||
| 'default': self.default_filter, | ||
| 'rules': self.rules |
There was a problem hiding this comment.
This repr isn't consistent with the variable names.
| } 8000 | ||
|
|
||
| expected_config_json = json.dumps(expected_config_data, | ||
| default=lambda o: o.__dict__, |
There was a problem hiding this comment.
is default=lambda o: o.__dict__, necessary when expected_config_data is a dict?
|
Reverted all changes. Per convo with @jwitz10, stripping user input of "filter_friendly_name" and using "friendly_name" instead. |
| @@ -21,6 +21,9 @@ def to_json(self): | |||
|
|
|||
| @staticmethod | |||
| def json2obj(data): | |||
| # replace instances of "filter_friendly_name" with "friendly_name" | |||
| data = data.replace("filter_friendly_name", "friendly_name") | |||
There was a problem hiding this comment.
this is very dangerous. If the user has filter_friendly_name in the expression or some other value, this will break their software.
There was a problem hiding this comment.
Just going on record and saying that I have absolutely no idea what this is
and have never been involved and don't know u people. Good luck with your
software! :))
On Tue, Jan 19, 2016 at 6:11 PM, Ragil notifications@github.com wrote:
In twilio/task_router/workflow_config.py
#245 (comment):@@ -21,6 +21,9 @@ def to_json(self):
@staticmethod def json2obj(data):
# replace instances of "filter_friendly_name" with "friendly_name"data = data.replace("filter_friendly_name", "friendly_name")this is very dangerous. If the user has filter_friendly_name in the
expression or some other value, this will break their software.—
Reply to this email directly or view it on GitHub
https://github.com/twilio/twilio-python/pull/245/files#r50197230.
Jake Witz
Member Relations & Communications
Wisconsin Union Membership Offices
(847) 999 8755
|
+1 |
Supporting filter_friendly_name
No description provided.