8000 Fix fetch offset type by Nevon · Pull Request #998 · tulios/kafkajs · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch offset type #998

Merged
merged 3 commits into from
Jan 8, 2021
Merged
8000

Fix fetch offset type #998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2c5711
Mark admin.fetchOffsets with single topic as deprecated
Nevon Jan 7, 2021
d3460bb
Change FetchOffsetsPartitions to object instead of array
Nevon Jan 7, 2021
ccea197
Fix typo
Nevon Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export type RequestQueueSizeEvent = InstrumentationEvent<{

export type SeekEntry = PartitionOffset

export type FetchOffsetsPartitions = Array<PartitionOffset & { metadata: string | null }>
export type FetchOffsetsPartition = PartitionOffset & { metadata: string | null }
export interface Acl {
principal: string
host: string
Expand Down Expand Up @@ -433,16 +433,19 @@ export type Admin = {
topicPartitions: ITopicPartitionConfig[]
}): Promise<boolean>
fetchTopicMetadata(options?: { topics: string[] }): Promise<{ topics: Array<ITopicMetadata> }>
/**
* @deprecated "topic: string" replaced by "topics: string[]"
*/
fetchOffsets(options: {
groupId: string
topic: string
resolveOffsets?: boolean
}): Promise<FetchOffsetsPartitions>
}): Promise<FetchOffsetsPartition[]>
fetchOffsets(options: {
groupId: string
topics?: string[]
resolveOffsets?: boolean
}): Promise<Array<{topic: string, partitions: FetchOffsetsPartitions}>>
}): Promise<Array<{topic: string, partitions: FetchOffsetsPartition[]}>>
fetchTopicOffsets(topic: string): Promise<Array<SeekEntry & { high: string; low: string }>>
fetchTopicOffsetsByTimestamp(topic: string, timestamp?: number): Promise<Array<SeekEntry>>
describeCluster(): Promise<{
Expand Down
0