8000 Fix fetch offset type by Nevon · Pull Request #998 · tulios/kafkajs · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetch offset type #998

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix fetch offset type #998

merged 3 commits into from
Jan 8, 2021

Conversation

Nevon
Copy link
Collaborator
@Nevon Nevon commented Jan 7, 2021

One millisecond after merging #992 I noticed a few small things to improve in the typings. This removes an exported type, but given that the beta package containing it isn't even out yet, I highly doubt anyone is using it. 😅

@Nevon Nevon requested review from tulios and JaapRood January 7, 2021 19:11
ankon
ankon approved these changes 8000 Jan 8, 2021
View reviewed changes
@Nevon Nevon merged commit 2068293 into master Jan 8, 2021
@Nevon Nevon deleted the fix-fetch-offset-type branch January 8, 2021 09:14
@JaapRood
Copy link
Collaborator
JaapRood commented Jan 8, 2021 •
edited
Loading

Really glad @ankon is picking up my reviewer slack, thanks :)

This was referenced Sep 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankon ankon ankon approved these changes

@tulios tulios Awaiting requested review from tulios

@JaapRood JaapRood Awaiting requested review from JaapRood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nevon @JaapRood @ankon
0