8000 build: update listings to use smp by jajanusz · Pull Request #60 · thesofproject/sof-docs · GitHub
[go: up one dir, main page]
Skip to content

build: update listings to use smp#60

Merged
lgirdwood merged 1 commit intothesofproject:masterfrom
jajanusz:use-default-smp-forcavs1_5
Nov 7, 2018
Merged

build: update listings to use smp#60
lgirdwood merged 1 commit intothesofproject:masterfrom
jajanusz:use-default-smp-forcavs1_5

Conversation

@jajanusz
Copy link
Contributor
@jajanusz jajanusz commented Nov 7, 2018

Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com

@jajanusz
build: update listings to use smp
dcca7e0 
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
@lgirdwood lgirdwood merged commit 64f7d43 into thesofproject:master Nov 7, 2018
@lgirdwood
Copy link
Member
lgirdwood commented Nov 7, 2018

@xiulipan can you add these SMP configs into CI. Thanks !

@xiulipan
Copy link
Contributor
xiulipan commented Nov 8, 2018

@lgirdwood
I got confused. So this is some new option or just replacement to the old options?
If it is some replacement, I will change the CI.
If it is some addition, we should not delete old configure in the doc.

@lgirdwood
Copy link
Member
lgirdwood commented Nov 8, 2018

@xiulipan it's an additional build for platforms > 1 core.

@xiulipan
Copy link
Contributor
xiulipan commented Nov 8, 2018

@lgirdwood
OK, will add this configure into build all scripts first.
Will name apl_smp and cnl_smp good?
@jajanusz
As this is some additional build, I think you can have more lines about this.
Not just some simple replacement.

@jajanusz
Copy link
Contributor Author
jajanusz commented Nov 8, 2018

@lgirdwood @xiulipan SMP should be default build for all multicore platforms (APL and above), because of having UP as default so far there are some bugs that got unnoticed by CI - like too small memory sections when building for SMP which is our default target for these platforms - thesofproject/sof#455 broke it

I'd wait with adding this to CI until memory section fix is merged (should be today), I can change SMP to be default build in xtensa-build-all.sh when it will be merged

@jajanusz
Copy link
Contributor Author
jajanusz commented Nov 8, 2018

As this is some additional build, I think you can have more lines about this.
Not just some simple replacement.

@xiulipan As i wrote it's not additional build, what you had before can be considered additional build for these platforms, SMP is default for APL+, UP for earlier like BYT ;)

@xiulipan
Copy link
Contributor
xiulipan commented Nov 8, 2018

@jajanusz
If this is some default change. I think nothing is need for CI.
You need to just change the xtensa-build-all.sh and will enable CI build check.

@jajanusz jajanusz deleted the use-default-smp-forcavs1_5 branch November 14, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jajanusz @lgirdwood @xiulipan

Comments
0