8000 debugability: macro metaprogramming refactor by mwierzbix · Pull Request #455 · thesofproject/sof · GitHub
[go: up one dir, main page]
Skip to content

debugability: macro metaprogramming refactor#455

Merged
lgirdwood merged 1 commit intothesofproject:masterfrom
mwierzbix:debugability
Nov 2, 2018
Merged

debugability: macro metaprogramming refactor#455
lgirdwood merged 1 commit intothesofproject:masterfrom
mwierzbix:debugability

Conversation

@mwierzbix
Copy link
Contributor
@mwierzbix mwierzbix commented Oct 3, 2018 •
edited
Loading

Added macro functions to make repetitive, nearly identical functions more maintainable via metaprogramming. They generate code in pre-compile, conceptually similar to C++17 if-constexpr.
sof/trace, host/trace: rewrote _trace_events using preproc-metaprog.
test/cmocka/include/test_group_generator: rewrote macros to not conflict with new ones.
Additionally, added unit tests for lib/preproc.h, and debugability macros.

Signed-off-by: Michal Jerzy Wierzbicki michalx.wierzbicki@linux.intel.com

@mwierzbix mwierzbix mentioned this pull request Oct 3, 2018
Closed
akloniex
akloniex reviewed Oct 3, 2018
View reviewed changes
lgirdwood
lgirdwood requested changes Oct 3, 2018
View reviewed changes
mwierzbix
mwierzbix commented Oct 9, 2018
View reviewed changes
@mwierzbix
Copy link
Contributor Author
mwierzbix commented Oct 9, 2018

From Travis

In file included from ../../src/include/sof/trace.h:42,
                 from ../../src/include/sof/interrupt.h:38,
                 from ../../src/include/sof/lock.h:42,
                 from ../../src/include/sof/dma.h:44,
                 from dma.c:31:
dma.c: In function 'dma_get':
../../src/include/sof/trace.h:253:16: error: '_trace_event4' undeclared (first use in this function); did you mean '_trace_event3'?
  __log_message(_trace_event##mbox##atomic, level, \

Now that was unexpected...

@mwierzbix mwierzbix force-pushed the debugability branch 2 times, most recently from 582c689 to 9c497ff Compare October 10, 2018 08:58
@lgirdwood
Copy link
Member
lgirdwood commented Oct 11, 2018

@mwierzbix build breakage.

lgirdwood
lgirdwood requested changes Oct 11, 2018
View reviewed changes
@mwierzbix
Copy link
Contributor Author
mwierzbix commented Oct 11, 2018

@lgirdwood @akloniex PR ready to be merged.

mwierzbix
mwierzbix commented Oct 11, 2018
View reviewed changes
@mwierzbix mwierzbix requested a review from mmaka1 October 11, 2018 13:50
@mwierzbix mwierzbix mentioned this pull request Oct 11, 2018
Merged
@mwierzbix mwierzbix force-pushed the debugability branch 4 times, most recently from 139ea66 to ea9d124 Compare October 15, 2018 14:01
@mwierzbix mwierzbix closed this Oct 15, 2018
@mwierzbix mwierzbix reopened this Oct 15, 2018
lgirdwood
lgirdwood reviewed Oct 15, 2018
View reviewed changes
@mwierzbix mwierzbix force-pushed the debugability branch 2 times, most recently from 4632119 to ef394a5 Compare October 16, 2018 11:50
@lgirdwood
Copy link
Member
lgirdwood commented Oct 17, 2018

@slawblauciak can you review the cmocka parts

slawblauciak
slawblauciak approved these changes Oct 17, 2018
View reviewed changes
Copy link
Collaborator
@slawblauciak slawblauciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mwierzbix
Copy link
Contributor Author
mwierzbix commented Oct 31, 2018

@slawblauciak cmocka parts changed in new commit.

lgirdwood
lgirdwood requested changes Oct 31, 2018
View reviewed changes
Copy link
Member
@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting and could you remove the merge commit from the PR. Thanks,.

@mwierzbix
debugability: Macro Metaprogramming Refactor
b284ac3 
Added macro functions to make repetitive, nearly identical functions more maintainable via metaprogramming. They generate code in pre-compile, conceptually similar to C++17 if-constexpr.  sof/trace, host/trace: rewrote _trace_event/d+ functions using preproc.h. test/cmocka/include/test_group_generator: rewrote macros to not conflict with new ones. Added unit tests to check whether more advanced and less obvious macros do in fact work.

Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
@lgirdwood lgirdwood merged commit 33e4b99 into thesofproject:master Nov 2, 2018
@mwierzbix mwierzbix deleted the debugability branch November 5, 2018 09:25
@jajanusz jajanusz mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akloniex akloniex akloniex left review comments

@lgirdwood lgirdwood lgirdwood requested changes

@slawblauciak slawblauciak slawblauciak approved these changes

@mmaka1 mmaka1 Awaiting requested review from mmaka1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mwierzbix @lgirdwood @slawblauciak @akloniex
0