Adds rake task variant for eliminating entire applications #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task: - the behavior when an app is provided but a queue name is omitted is surprising and potentially destructive - an application that uses multiple queues would require multiple runs of the task to fully decomission Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services.
tomaszwro
approved these changes
Jul 26, 2024
| elsif app_key | ||
| manager.unsubscribe_app!(app_key) | ||
| else | ||
| manager = ::QueueBus::TaskManager.new(true) |
stadori
added a commit
that referenced
this pull request
Jun 16, 2025
* Adds rake task variant for eliminating entire applications (#1) * Adds rake task variant for eliminating entire applications The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task: - the behavior when an app is provided but a queue name is omitted is surprising and potentially destructive - an application that uses multiple queues would require multiple runs of the task to fully decomission Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services. * Bumps version to 0.13.3 * sadd deprecation fix for redis 4-8-1 * version update * changelog --------- Co-authored-by: Drew Long <48696687+aalong-tr@users.noreply.github.com> Co-authored-by: Shyamsunder Tadori <shyamsundertadori@Shyamsunders-MacBook-Pro-2.local>
stadori
added a commit
that referenced
this pull request
Jun 23, 2025
* Adds rake task variant for eliminating entire applications (#1) * Adds rake task variant for eliminating entire applications The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task: - the behavior when an app is provided but a queue name is omitted is surprising and potentially destructive - an application that uses multiple queues would require multiple runs of the task to fully decomission Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services. * Bumps version to 0.13.3 * pipelined deprecation fix * version update --------- Co-authored-by: Drew Long <48696687+aalong-tr@users.noreply.github.com> Co-authored-by: Shyamsunder Tadori <shyamsundertadori@Shyamsunders-MacBook-Pro-2.local>
aalong-tr
added a commit
that referenced
this pull request
Jun 23, 2025
* Adds rake task variant for eliminating entire applications (#1) * Adds rake task variant for eliminating entire applications The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task: - the behavior when an app is provided but a queue name is omitted is surprising and potentially destructive - an application that uses multiple queues would require multiple runs of the task to fully decomission Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services. * Bumps version to 0.13.3 * setnx deprecation fix * version update --------- Co-authored-by: Drew Long <48696687+aalong-tr@users.noreply.github.com> Co-authored-by: Shyamsunder Tadori <shyamsundertadori@Shyamsunders-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task:
Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services.