Sadd deprecation warning fix for redis 4 8 1 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds rake task variant for eliminating entire applications The unsubscribe rake task, when passed two arguments, does not appear to actually delete any subscriptions. The exact reason for this is not obvious, but this is far from the only problem with the task: - the behavior when an app is provided but a queue name is omitted is surprising and potentially destructive - an application that uses multiple queues would require multiple runs of the task to fully decomission Solve both of these problems with a new code path that unsubscribes a single application in its entirety. This code path already existed, but was unreachable as a safeguard against shared applications conflicting across services. * Bumps version to 0.13.3
aalong-tr
approved these changes
Jun 13, 2025
Collaborator
There was a problem hiding this comment.
It doesn't look like the return value of either sadd call is ever used so this should be fine, thank you!
| ## [Unreleased] | ||
|
|
||
| ## [0.13.4] | ||
| - Removes sadd usage in favor of sadd? |
Collaborator
There was a problem hiding this comment.
Can we please expand this to explain that this is to address a deprecation warning in preparation for Redis 5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the following deprecation warning on Redis-4.8.1
Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead