Type hint webhooks #945
Merged
Type hint webhooks #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following notes from GVR on python/mypy#1362
Development of distutils has stopped. Removing refs to it. https://pypi.org/project/Distutils2/
commit 2609e27 Merge: d107c48 3a8ec6c Author: Chris Shin <cshin@tableau.com> Date: Wed Feb 17 16:00:42 2021 -0800 Merge pull request tableau#803 from tableau/release-0.15 syncing development branch with v0.15 changelog commit d107c48 Author: Tyler Doyle <doyle.tyler@gmail.com> Date: Wed Feb 17 15:38:14 2021 -0800 Add Mypy to CI runs (tableau#802) Add mypy runs to CI, but skip misc errors, so we only see the important stuff. For now these are non blocking. commit 3a8ec6c Merge: 004ab31 a5b9252 Author: Chris Shin <cshin@tableau.com> Date: Tue Feb 16 16:51:37 2021 -0800 Merge branch 'master' into release-0.15 commit 004ab31 Author: Chris Shin <cshin@tableau.com> Date: Tue Feb 16 16:49:19 2021 -0800 Updates changelog and contributors list for v0.15 commit 6c7a87b Author: Chris Shin <cshin@tableau.com> Date: Tue Feb 16 15:09:45 2021 -0800 Removes travis and adds linting/testing into github action (tableau#798) * Removes travis and adds github workflow * Addressing code review feedback commit 9179637 Author: Lee Boynton <lee@lboynton.com> Date: Tue Feb 16 23:09:22 2021 +0000 Add support for getting groups that a user belongs to (tableau#799) * Add support for getting groups that a user belongs to * Use more descriptive name for pager function commit fe992ee Author: Chris Shin <cshin@tableau.com> Date: Tue Feb 16 14:33:59 2021 -0800 [Tasks] Translate task type from server to TSC enum (tableau#796) * Adds task type mapping to translate server response * Updates tests to match server response for task type * Fixes pycodestyle error commit f64fcf9 Author: John Vandenberg <jayvdb@gmail.com> Date: Wed Feb 17 01:21:46 2021 +0800 MANIFEST.in: Add docs and test data (tableau#780) * Update publish_workbook.py (tableau#694) * Update publish_workbook.py Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online parser.add_argument('--sitename', '-S', default='', help='sitename required') tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename) * Update publish_workbook.py Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error. * Update publish_workbook.py * Merge pull request tableau#745 from tableau/fix_732 Server versions before 2020.1 do not accept encoded query param delimiters * Merge pull request tableau#757 from tableau/fix_754 Fixes issue tableau#754 by moving file read logic inside generator * Updates changelog for v0.14.1 * MANIFEST.in: Add docs and test data Closes tableau#779 Co-authored-by: Chris Shin <cshin@tableau.com> Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM> commit 88a0188 Author: Chris Shin <cshin@tableau.com> Date: Tue Feb 16 09:17:35 2021 -0800 [Subscriptions] Add new fields and ability to update (tableau#794) * Add fields and parsing logic * Update subscription create request * Adds update request to subscriptions * Changes subscription change request creation to use tsrequest annotation * Update tests for parsing new fields * Fixes codestyle issues * Removes user and schedule name * Fixes test failure commit 026bca8 Author: Chris Shin <cshin@tableau.com> Date: Thu Feb 11 15:34:08 2021 -0800 Adds skipConnectionCheck to publish workbook (tableau#791) * Adds skipConnectionCheck flag to publish workbook * Removes unnecessary lines * Fixes style error commit 857199b Author: tjones-commits <70481977+tjones-commits@users.noreply.github.com> Date: Fri Feb 5 17:09:32 2021 -0500 Update site properties and functions (tableau#777) * Update publish_workbook.py (tableau#694) * Update publish_workbook.py Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online parser.add_argument('--sitename', '-S', default='', help='sitename required') tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename) * Update publish_workbook.py Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error. * Update publish_workbook.py * Merge pull request tableau#745 from tableau/fix_732 Server versions before 2020.1 do not accept encoded query param delimiters * Merge pull request tableau#757 from tableau/fix_754 Fixes issue tableau#754 by moving file read logic inside generator * Updates changelog for v0.14.1 * update the site item to reflect api response * update test model * remove extra test assets * trimming line length * unit test all properties. fix some properties. Remove extra code * make requested changes * make requested changes Co-authored-by: Chris Shin <cshin@tableau.com> Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM> Co-authored-by: Terrence Jones <tjones@arkatechture.com> commit a5b9252 Merge: bcb881c 1fc349c Author: Chris Shin <cshin@tableau.com> Date: Thu Dec 10 09:29:42 2020 -0800 Merge pull request tableau#759 from tableau/0.14.0-patch v0.14.1 patch release * Fixed filter query issue for server version below 2020.1 (tableau#745) * Fixed large workbook/datasource publish issue (tableau#757) commit 1fc349c Author: Chris Shin <cshin@tableau.com> Date: Wed Dec 9 16:30:03 2020 -0800 Updates changelog for v0.14.1 commit 41fd8f2 Author: Chris Shin <cshin@tableau.com> Date: Wed Dec 9 15:49:48 2020 -0800 Merge pull request tableau#757 from tableau/fix_754 Fixes issue tableau#754 by moving file read logic inside generator commit 138476f Author: Chris Shin <cshin@tableau.com> Date: Wed Dec 9 15:49:23 2020 -0800 Merge pull request tableau#745 from tableau/fix_732 Server versions before 2020.1 do not accept encoded query param delimiters commit bcb881c Merge: 8d51355 1e089b4 Author: Chris Shin <cshin@tableau.com> Date: Mon Nov 9 09:19:23 2020 -0800 Merge pull request tableau#725 from tableau/development Syncing master with v0.14.0 changes from development. commit 8d51355 Author: Madhura Selvarajan <MADHURA0910@GMAIL.COM> Date: Wed Sep 23 10:45:27 2020 -0400 Update publish_workbook.py (tableau#694) * Update publish_workbook.py Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online parser.add_argument('--sitename', '-S', default='', help='sitename required') tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename) * Update publish_workbook.py Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error. * Update publish_workbook.py commit 273af7a Merge: 43e1b06 168489c Author: Chris Shin <cshin@tableau.com> Date: Wed Sep 2 14:39:13 2020 -0700 Merge pull request tableau#685 from tableau/development [v0.13] Merge development into master Added notes field to JobItem (tableau#571) Added webpage_url field to WorkbookItem (tableau#661) Added support for switching between sites (tableau#655) Added support for querying favorites for a user (tableau#656) Added support for Python 3.8 (tableau#659) Added support for Data Alerts (tableau#667) Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (tableau#672) Added support for creating and querying Active Directory groups (tableau#674) Added support for asynchronously updating a group (tableau#674) Improved handling of invalid dates (tableau#529) Improved consistency of update_permission endpoints (tableau#668) Documentation updates (tableau#658, tableau#669, tableau#670, tableau#673, tableau#683)
t8y8
approved these changes
Nov 3, 2021
073bb60 to
7e88cfa
Compare
commit ed940a2 Author: Jac <jacalata@users.noreply.github.com> Date: Thu Jan 27 20:16:31 2022 -0800 make tests run even if code style fails (tableau#980) commit fb49f31 Author: jorwoods <jorwoods@users.noreply.github.com> Date: Thu Jan 27 21:54:31 2022 -0600 Jorwoods/type hint flows (tableau#937) * Type hint Flows * Type hint request_factory for flows * Add ConnectionItem type hints on to Flow publish request * Clean up flows publish signature * Fix flow update_permissions type hint * Fix update_permissions type hint * Add workbook.hidden_views type hint * Update permissions only accepts an iterable * Fix formatting commit f40d4bc Author: jorwoods <jorwoods@users.noreply.github.com> Date: Thu Jan 27 21:47:53 2022 -0600 Jorwoods/type hint favorites (tableau#936) * Type hint Favorites * Type hint FavoriteRequest commit 4d0142d Author: jorwoods <jorwoods@users.noreply.github.com> Date: Thu Jan 27 21:45:14 2022 -0600 Jorwoods/type hint data alert (tableau#934) * Type hint data alerts * Type hint DataAlertRequest * Remove type annotations from Frequency namespace * Update test_dataalert.py commit b836f33 Author: Brian Cantoni <bcantoni@salesforce.com> Date: Thu Jan 27 19:29:50 2022 -0800 WIP: Enable Black for CI and add as dependency (tableau#935) * Enable Black for CI and add as dependency * Bulk reformat with Black, line length 120 Co-authored-by: Jac Fitzgerald <jac.fitzgerald@salesforce.com> commit ad57851 Author: jorwoods <jorwoods@users.noreply.github.com> Date: Thu Nov 11 15:55:01 2021 -0600 Jorwoods/type hint revisions (tableau#956) Add type hints and tests for workbook and data source revisions commit bb0feb8 Author: elsherif <selsherif@tableau.com> Date: Wed Nov 10 01:21:16 2021 +0100 Add support to datasource and workbook revisions (tableau#931) * add support to datasource and workbook revisions (get all item revisions / downlad item by revision number) * add type hints * remove wrong type hints commit 31d420f Author: Stephen Mitchell <scum@mac.com> Date: Tue Nov 9 01:02:14 2021 -0500 Clean up hidden_views by making it an attribute of WorkbookItem (tableau#617) * Clean up hidden views and make it an attribute of workbookitem * Pycodestyle error fix for one letter variable Co-authored-by: Jac <jacalata@users.noreply.github.com> Co-authored by: Stephen Mitchell https://github.com/scuml commit 7443f68 Author: jorwoods <jorwoods@users.noreply.github.com> Date: Sun Nov 7 05:57:42 2021 -0600 Add type hints to `Job` (tableau#939) commit c8170ae Author: Tyler Doyle <doyle.tyler@gmail.com> Date: Mon Nov 1 20:36:17 2021 -0400 Fix slack once and for all (tableau#946) The red X keeps coming back so I'd like to mark this as allowably fail-able -- that way the innards of Slack/OAuth/Tableau credentials don't keep polluting test run reports :) commit 946469c Author: jorwoods <jorwoods@users.noreply.github.com> Date: Mon Nov 1 14:33:22 2021 -0500 Type hinting on Datasources and Workbooks (tableau#804) Adds types to function signatures for Workbook and Data Source endpoints. Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com> commit feed39c Author: Brian Cantoni <bcantoni@tableau.com> Date: Tue Oct 26 08:04:10 2021 -0700 Switch to release Python 3.10 release for CI (tableau#927) * Switch to release Python 3.10 release for CI commit 4007d3d Author: Jac <jacalata@users.noreply.github.com> Date: Fri Oct 22 19:06:20 2021 -0700 Jac/publish samples (tableau#918) * add publish-samples option to create/update project commit a899a95 Author: mmuttreja-tableau <87720143+mmuttreja-tableau@users.noreply.github.com> Date: Thu Oct 21 12:10:37 2021 -0400 Adjusting changelog to include missing updates for release 0.17 (tableau#922) commit f81039a Merge: fefd6f1 46bbe2e Author: mmuttreja-tableau <87720143+mmuttreja-tableau@users.noreply.github.com> Date: Wed Oct 20 17:43:50 2021 -0400 Merge pull request tableau#921 from tableau/development Merging Development to Main branch for releasing v 0.17 commit 46bbe2e Author: mmuttreja-tableau <87720143+mmuttreja-tableau@users.noreply.github.com> Date: Wed Oct 20 17:26:45 2021 -0400 Update contributors and Changelog for Release 0.17 (tableau#920) * Update CONTRIBUTORS.md & changelog for v 0.17 Update contributors & changelog for v 0.17 commit 428eb55 Author: jorwoods <jorwoods@users.noreply.github.com> Date: Tue Oct 19 12:32:51 2021 -0500 Add FlowRun Item and Endpoints. (tableau#884) * Add tests for fetching flow runs * Implement basics of FlowRuns * Add tests for cancel flow run * Make FlowRuns a Queryset endpoint for easier filtering * Add test for flow refresh endpoint * Align to naming conventions * Apply name change consistently * Change flowrun_id into flow_run_id * Add wait_for_job to FlowRun * Tag wait_for_job with version number * Rewrite flow_run to use ExponentialBackoffTimer * Test flow run wait with backoff * Remove 3.5 from test matrix * Standardize spelling of cancelled Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com> commit fefd6f1 Merge: 1d8a9be 0845b7b Author: Jac <jacalata@users.noreply.github.com> Date: Thu Sep 2 17:49:07 2021 -0700 Merge pull request tableau#880 from tableau/upgrade-slack-action Upgrade to newer Slack action provider commit 0845b7b Author: Brian Cantoni <bcantoni@tableau.com> Date: Wed Sep 1 14:22:53 2021 -0700 Upgrade to newer Slack action provider commit 1d8a9be Merge: 5cbfc34 770d48a Author: Ovini Nanayakkara <44311587+ovinis@users.noreply.github.com> Date: Fri Jul 16 12:42:30 2021 -0400 Merge pull request tableau#864 from tableau/development Merging Development to Main branch commit 5cbfc34 Merge: ec3cc50 ffefd80 Author: Jac <jacalata@users.noreply.github.com> Date: Wed Jun 23 23:33:47 2021 -0700 Merge pull request tableau#851 from tableau/jacalata-patch-1 Create slack.yml action commit ffefd80 Author: Jac <jacalata@users.noreply.github.com> Date: Mon May 24 13:34:07 2021 -0700 whitespace change to re-try PR commit 0c4fd4a Author: Jac <jacalata@users.noreply.github.com> Date: Mon May 24 13:15:49 2021 -0700 Create slack.yml Created a new action from https://github.com/marketplace/actions/send-message-to-slack
7e88cfa to
f634580
Compare
jacalata
pushed a commit
that referenced
this pull request
Mar 30, 2022
jacalata
pushed a commit
that referenced
this pull request
Jun 1, 2022
jacalata
pushed a commit
that referenced
this pull request
Jun 6, 2022
jacalata
pushed a commit
that referenced
this pull request
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints onto webhooks