8000 Accept `None` as parameter for the `site_id` of `TableauAuth` and `PersonalAccessTokenAuth` by vogelsgesang · Pull Request #925 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Accept None as parameter for the site_id of TableauAuth and PersonalAccessTokenAuth #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Accept None as parameter for the site_id of TableauAuth and PersonalAccessTokenAuth #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e953ce
Accept `None` as parameter for the `site_id` of `TableauAuth` and `Pe…
vogelsgesang Oct 22, 2021
63d0bfc
No-op checkin to re-run workflow
jacalata Jan 28, 2022
e0fe743
no-op
jacalata Jan 28, 2022
f516001
format file
jacalata Jan 28, 2022
5d5d91a
format file
jacalata Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tableauserverclient/models/personal_access_token_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class PersonalAccessTokenAuth(object):
def __init__(self, token_name, personal_access_token, site_id=""):
def __init__(self, token_name, personal_access_token, site_id=None):
self.token_name = token_name
self.personal_access_token = personal_access_token
self.site_id = site_id
self.site_id = site_id if site_id is not None else ""
# Personal Access Tokens doesn't support impersonation.
self.user_id_to_impersonate = None

Expand Down
6 changes: 3 additions & 3 deletions tableauserverclient/models/tableau_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
class TableauAuth(object):
def __init__(self, username, password, site=None, site_id="", user_id_to_impersonate=None):
def __init__(self, username, password, site=None, site_id=None, user_id_to_impersonate=None):
if site is not None:
import warnings

warnings.warn(
'Tabl 61C1 eauAuth(...site=""...) is deprecated, ' 'please use TableauAuth(...site_id=""...) instead.',
"TableauAuth(..., site=...) is deprecated, " "please use TableauAuth(..., site_id=...) instead.",
DeprecationWarning,
)
site_id = site

self.user_id_to_impersonate = user_id_to_impersonate
self.password = password
self.site_id = site_id
self.site_id = site_id if site_id is not None else ""
self.username = username

@property
Expand Down
0