Accept None as parameter for the site_id of TableauAuth and PersonalAccessTokenAuth
#925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rsonalAccessTokenAuth` As part of tableau#889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion. Fixes tableau#924
|
Technically It’s a sin that we’ve been paying for since 7.0 when sites were introduced :( I don’t think it’s safe to default to |
|
Also the slack error is back and blocking test runs. We shouldn’t reintroduce the slack message until we know it will be stable. |
|
I don't think this should break anything, the change doesn't affect further than the code shown since it will set the value to '' anyway. |
|
updated so it only has the same type failures as the development branch, will merge into there. |
…rsonalAccessTokenAuth` (#925) * Accept `None` as parameter for the `site_id` of `TableauAuth` and `PersonalAccessTokenAuth` As part of #889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion. Fixes #924
As part of #889, I changed the default value for the
siteargument to beNoneinstead of an empty string. This accidentally broke auth, as
TableauAuthexpected an empty string instead of
Noneto signify an absentsiteargument.This commit fixes the issue by now actually accepting
Noneassite_idinTableauAuthandPersonalAccessTokenAuth, thereby making our interface moreintuitive, at least in my opinion.
Fixes #924