Unify arguments of sample scripts #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelsgesang
added a commit
to vogelsgesang/server-client-python
that referenced
this pull request
Sep 18, 2021
Change the docs to be in sync with PR tableau#889
|
@vogelsgesang I'll go thru and review these. Have you done some manual testing with the new versions of all these scripts? Wondering if you need just a quick review or someone to test them as well. |
|
I did test most of them against AlpoDev on Tableau Online. Some of them failed (e.g., |
I am pretty new to TSC, and wanted to run some sample scripts to get an understanding of the library. Doing so, I realized that every sample had a slightly different command line, even for common arguments: * Some expected `site`, some `site-id`, some were lacking site-support completely (and thereby unusable for Tableau Online) * Some had a short option `-i`, some had the short option `-S` for the site name * Some expected password-based authentication, some expected personal access tokens This commit fixes all those inconsistencies, so that users don't have to re-learn the command line options for each individual script.
c1ec230 to
74bec02
Compare
|
rebased on |
vogelsgesang
added a commit
to vogelsgesang/server-client-python
that referenced
this pull request
Oct 22, 2021
…rsonalAccessTokenAuth` As part of tableau#889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion.
vogelsgesang
added a commit
to vogelsgesang/server-client-python
that referenced
this pull request
Oct 22, 2021
…rsonalAccessTokenAuth` As part of tableau#889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion. Fixes tableau#924
jacalata
pushed a commit
that referenced
this pull request
Jan 28, 2022
…rsonalAccessTokenAuth` (#925) * Accept `None` as parameter for the `site_id` of `TableauAuth` and `PersonalAccessTokenAuth` As part of #889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion. Fixes #924
jacalata
pushed a commit
that referenced
this pull request
Mar 30, 2022
…rsonalAccessTokenAuth` (#925) * Accept `None` as parameter for the `site_id` of `TableauAuth` and `PersonalAccessTokenAuth` As part of #889, I changed the default value for the `site` argument to be `None` instead of an empty string. This accidentally broke auth, as `TableauAuth` expected an empty string instead of `None` to signify an absent `site` argument. This commit fixes the issue by now actually accepting `None` as `site_id` in `TableauAuth` and `PersonalAccessTokenAuth`, thereby making our interface more intuitive, at least in my opinion. Fixes #924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty new to TSC, and wanted to run some sample scripts to get an
understanding of the library. Doing so, I realized that every sample
had a slightly different command line, even for common arguments:
site, somesite-id, some were lacking site-supportcompletely (and thereby unusable for Tableau Online)
-i, some had the short option-Sfor thesite name
access tokens
This commit fixes all those inconsistencies, so that users don't have
to re-learn the command line options for each individual script.