8000 Replacing the feature name "materialized views" with "data acceleration" by guodah · Pull Request #576 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Replacing the feature name "materialized views" with "data acceleration" #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 3, 2020
Merged

Replacing the feature name "materialized views" with "data acceleration" #576

merged 17 commits into from
Mar 3, 2020

Conversation

guodah
Copy link
Contributor
@guodah guodah commented Mar 1, 2020

The feature "Materialized Views" has been replaced with "Data Acceleration" in the server code, including the rest api schema and urls. This PR is to make the name change in the client side.

guodah and others added 16 commits December 17, 2019 23:28
@guodah
Merge pull request #1 from tableau/development
d2e76ca 
Add support for materializeViews as schedule and task type (tableau#542)
@guodah
fixing a bug due to bool(time(0,0)) is false
74af749
@guodah
Merge pull request #2 from tableau/development
6c47060 
Development
@guodah
Merge pull request #3 from tableau/development
7037289 
Receiving warnings in schedule creation (tableau#550)
@guodah
Merge pull request #4 from tableau/development
08be1a7 
Development
@guodah
replace materialized views with data acceleration
fb28098
@guodah
Merge pull request #5 from guodah/replace_mat_views_with_data_acceler…
91ddf68 
…ation

replace materialized views with data acceleration
@guodah
made changes in tests
c93a400
@guodah
Merge pull request #6 from guodah/replace_mat_views_with_data_acceler…
d9061fd 
…ation

made changes in tests
@guodah
fixed a unit test
2064f6d
@guodah
restore deleted lines by mistake
2a05834
@guodah
replace materialize_workbooks.py with accelerate_workbooks.py
592716c
@guodah
undo a fix to test_sort.py
ccbf675
@guodah
format changes
8bc913e
@guodah
another format change
2721b2f
@guodah
format change
aea6a99
@shinchris
Copy link
Contributor

The changes themselves look good 😄
My only concern is that the sample might be too complex to be considered a useful sample for our users. Samples should capture specific and frequent scenarios that should be easy for a new user to refer to for examples of using the library.
Would it be possible to break this sample into specific scenarios? Doesn't have to be part of this MR, though, since this is for 2020.2.

@guodah
Copy link
Contributor Author
guodah commented Mar 3, 2020

Thanks for the speedy review! Our team wants to provide users with a "comprehensive" script to use our feature with different options as our feature does not have a UI yet.

Let me discuss with my team. :)

@shinchris shinchris merged commit 4122e9c into tableau:development Mar 3, 2020
@shinchris
Copy link
Contributor

Thanks @guodah !

@guodah guodah mentioned this pull request Mar 23, 2020
Merged
This was referenced May 1, 2020
Merged
Merged
shinchris pushed a commit that referenced this pull request May 1, 2020
Merge pull request #612 from tableau/development
188be71 
Merge development into master for v0.11 release

v0.11 (1 May 2020)

-Added more fields to Data Acceleration config (#588)
-Added OpenID as an auth setting enum (#610)
-Added support for Data Acceleration Reports (#596)
-Added support for view permissions (#526)
-Materialized views changed to Data Acceleration (#576)
-Improved consistency across workbook/datasource endpoints (#570)
-Fixed print error in update_connection.py (#602)
-Fixed log error in add user endpoint (#608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guodah @shinchris
0