-
Notifications
You must be signed in to change notification settings - Fork 436
Add flexibility for wkbk/ds id or item in endpoint #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexibility for wkbk/ds id or item in endpoint #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorwoods thanks for submitting a pull request for this!
Could you add some unit tests and also sign our Contributor License Agreement?
@@ -145,7 +145,8 @@ def update_connection(self, datasource_item, connection_item): | |||
return connection | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're making changes here, can you add the @api(version='2.8') annotation for the refresh method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shinchris I added the API decorator. I didn't see any existing unit tests for the refresh methods that I can expand upon. I need to read a little more about requests_mock to know how to write them appropriately for what this should accomplish.
@shinchris I tried creating a test response XML for the workbook refresh XML, but something is wrong with it. Can someone here take a look and help correct the XML response? |
I found the issue with the XML. I copied the response XML from https://help.tableau.com/v2019.3/api/rest_api/en-us/REST/rest_api_ref.htm#update_workbook_now but its missing the closing job tag. The documentation needs to be corrected. |
CLA has been signed and emailed in. |
Merge development into master for v0.11 release v0.11 (1 May 2020) -Added more fields to Data Acceleration config (#588) -Added OpenID as an auth setting enum (#610) -Added support for Data Acceleration Reports (#596) -Added support for view permissions (#526) -Materialized views changed to Data Acceleration (#576) -Improved consistency across workbook/datasource endpoints (#570) -Fixed print error in update_connection.py (#602) -Fixed log error in add user endpoint (#608)
This pull request makes a consistent but backwards compatible API for refreshes that accept either the item or it's id for both datasources and workbooks.
Would resolve #562