-
Notifications
You must be signed in to change notification settings - Fork 436
Merge multicredential and as job #313
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graysonarts
merged 26 commits into
tableau:development
from
graysonarts:merge_multicredential_and_as_job
Jul 10, 2018
Merged
Merge multicredential and as job #313
graysonarts
merged 26 commits into
tableau:development
from
graysonarts:merge_multicredential_and_as_job
Jul 10, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding all of the new site roles
Added support for asynchronous publishing on workbook and datasource endpoints
* Implement view filters on the populate* request options
* Adding export sample/tool * Removing unused import * Addressing code review feedback * Missed one description
* Change to correct parent project id tag name * Change to correct parent project id tag name
* add export_wb sample for 'fullpdf' * Addressing code review feedback from Lee * Fixing the dumb thing that I did where I was getting the view, then throwing it away and getting it again... * pep8 error
…entries. Tested manually, and a simple regression test added to the suite.
* addressing bug #281: update datasource connection not updating server port properly
…284) * adding ability to rename workbook using workbooks.update() * updating test
* Adding update method for groups * Add some docs * Add test for update group function
Taking @marianotn 's PR and updating it to retain backwards compatibility. Pre-implemented for datasources as well, though those don't support this server-side yet, I've set that version to 99.99. When support lands we can update it to the version it's introduced in.
* initial checkin for get background jobs * pep8 fixes * addressed code review feedback
* added cancel job * fixing whitespace issues * addressing small nits in the sample and the docs
* Adding chnagelog for 0.7 * Adding Sergey to contributors * Adding async to the changelog
Thank you @RussTheAerialist ! LGTM! |
t8y8
approved these changes
Jul 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a divergence that happened when something was checked into master rather than development. This is to try to merge it into development so that I can get development and master back in sync.