10000 Adding all of the new site roles by graysonarts · Pull Request #291 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Adding all of the new site roles #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2018
Merged

Adding all of the new site roles #291

merged 3 commits into from
May 8, 2018

Conversation

graysonarts
Copy link
Contributor

This is against master so I can release a 0.6.2 version

@graysonarts graysonarts requested a review from shinchris May 8, 2018 22:38
SiteAdministratorCreator = 'SiteAdministratorCreator'
SiteAdministratorExplorer = 'SiteAdministratorExplorer'
UnlicensedWithPublish = 'UnlicensedWithPublish'
ViewerWithPublish = 'ViewerWithPublish'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViewerWithPublish already exists on line 16.

shinchris
shinchris previously approved these changes May 8, 2018
t8y8
t8y8 previously approved these changes May 8, 2018
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 noting Chris' comment

@graysonarts graysonarts dismissed stale reviews from t8y8 and shinchris via 41e4c16 May 8, 2018 22:57
@graysonarts graysonarts merged commit 3fe62c9 into tableau:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0