8000 Jac/export sample fix by jacalata · Pull Request #1034 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Jac/export sample fix #1034

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2022
Merged

Jac/export sample fix #1034

merged 4 commits into from
May 23, 2022

Conversation

jacalata
Copy link
Contributor
@jacalata jacalata commented May 6, 2022

delete sample script that manually built a pdf of a whole workbook, replaced with direct call to do that
delete sample script that duplicated the 'export image' feature
replaced the need for filter-> list by called get_by_id

jacalata added 4 commits May 6, 2022 20:58
export_wb is no longer needed because we have workbook export
download_view_image is already in export, maybe just not findable?
@jacalata
Copy link
Contributor Author
jacalata commented May 6, 2022

Will fix #512

@jacalata jacalata merged commit e710a64 into development May 23, 2022
jacalata added a commit that referenced this pull request Jun 1, 2022
* delete redundant samples (export_wb, download_view_image)
* fix filter for python 3
* add workbook pdf download
@jacalata jacalata deleted the jac/export-sample-fix branch June 4, 2022 04:55
jacalata added a commit that referenced this pull request Jun 6, 2022
* delete redundant samples (export_wb, download_view_image)
* fix filter for python 3
* add workbook pdf download
jacalata added a commit that referenced this pull request Sep 20, 2022
* delete redundant samples (export_wb, download_view_image)
* fix filter for python 3
* add workbook pdf download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0