8000 Avoid common keywords as parameters · Issue #4 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Avoid common keywords as parameters #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
t8y8 opened this issue Sep 2, 2016 · 0 comments
Closed

Avoid common keywords as parameters #4

t8y8 opened this issue Sep 2, 2016 · 0 comments
Milestone
0.1

Comments

@t8y8
Copy link
Collaborator
t8y8 commented Sep 2, 2016

'input' and 'file' are both keywords and it's usually better to avoid them, especially in 'with' statements

They're used all over the codebase
@shinchris shinchris added this to the 0.1 milestone Sep 6, 2016
shinchris added a commit that referenced this issue Sep 7, 2016
@shinchris
Merge pull request #13 from tableau/bugfix-4-rename_keywords
1256c88 
#4 rename common keywords and reorder properties on item classes
@geordielad geordielad mentioned this issue Nov 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@t8y8 @shinchris
0