#4 rename common keywords and reorder properties on item classes #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,17 @@ | |||
| language: python | |||
There was a problem hiding this comment.
All of your PRs have this commit, which is causing merge conflicts, it'll need to be removed from these branches I think
There was a problem hiding this comment.
Hey @t8y8 this is a product of the rebasing usually if you don't force push to the branch, I'll take a look at Chris' changes on his machine when he gets in to make sure
|
🚀 for the rename of the variables (Thanks for the quick turnaround!!) -- but this PR has a lot in it that might be part of your other checkins? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the words 'file' and 'input' used throughout the codebase.
Also reorganized properties on item classes.