8000 use request stack rather than a single request by dbu · Pull Request #390 · symfony-cmf/routing-bundle · GitHub
[go: up one dir, main page]
Skip to content

use request stack rather than a single request #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2017
Merged

use request stack rather than a single request #390

merged 1 commit into from
Feb 21, 2017

Conversation

dbu
Copy link
Member
@dbu dbu commented Feb 18, 2017

defaults to false in 2.8 and triggers deprecation since symfony 3.3

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? see travis
Fixed tickets -
License MIT
Doc PR -

related to symfony/symfony#21662

@dbu dbu modified the milestone: 2.0 Feb 18, 2017
@dbu dbu mentioned this pull request Feb 19, 2017
Merged
@dbu dbu force-pushed the remove-strict branch 3 times, most recently from 83f5261 to dee4e63 Compare February 20, 2017 16:38
@dbu dbu changed the title this flag is ignored in symfony 3 use request stack rather than a single request Feb 20, 2017
wouterj
wouterj reviewed Feb 21, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -1,6 +1,8 @@
Changelog
=========

* **2017-02-17**: [BC BREAK] DynamicRouter::setRequest changed to DynamicRouter::setRequestStack for better DI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"[BC BREAK] DynamicRouter::setRequest() has been removed in favor of DynamicRouter::setRequestStack()."

I would not mention "for better DI", it sounds like a bit strange reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dbu dbu merged commit fa52e85 into master Feb 21, 2017
@dbu dbu deleted the remove-strict branch February 21, 2017 13:41
@dbu dbu removed the wip/poc label Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dbu @wouterj
0