add missing changelog for deprecated strict attribute #21662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2017
|
should we also enhance/instead the deprecation message in the code? |
|
if the flag can actually just be removed, that would be developer friendly i think. however, i just tried to fix this and with the head branch of symfony/symfony 2.8 i still get the "Scope Widening Injection detected". i understood that the latest symfony 2.8 was fixed to allow removing the parameter? |
|
only master has the deprecation about the strict attribute - not sure why you talk about 2.8 :) |
|
i maintain bundles that support both 2.8 and 3. #21058 (comment) made me think we can just remove the attribute but that fails on 2.8 while working in 3: symfony-cmf/routing-bundle#390 |
|
Thank you @dbu. |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- add missing changelog for deprecated strict attribute | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - since #21058, 3.3 triggers a deprecation when using the strict attribute. luckily wouter managed to find the reason and we figured out we can simply delete the attribute. having an upgrade file entry would make it easier to find the reason for the deprecation and be sure what to do. (assuming i understood the implications correctly) Commits ------- 2c5f879 add missing changelog for deprecated strict attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #21058, 3.3 triggers a deprecation when using the strict attribute. luckily wouter managed to find the reason and we figured out we can simply delete the attribute. having an upgrade file entry would make it easier to find the reason for the deprecation and be sure what to do. (assuming i understood the implications correctly)