8000 Error in the documentation · Issue #458 · symfony/webpack-encore · GitHub
[go: up one dir, main page]
Skip to content

Error in the documentation #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tim-arts opened this issue Nov 17, 2018 · 2 comments
Closed

Error in the documentation #458

Tim-arts opened this issue Nov 17, 2018 · 2 comments

Comments

@Tim-arts
Copy link
Tim-arts commented Nov 17, 2018 •
edited
Loading

At this link : https://symfony.com/doc/current/frontend/encore/split-chunks.html

Encore
    // ...

    .splitEntryChunks()
     .configureSplitChunks(function(splitChunks) {
         // change the configuration
         splitChunks.minSize = 0;
     }

Should be :

Encore
    // ...

    .splitEntryChunks()
     .configureSplitChunks(function(splitChunks) {
         // change the configuration
         splitChunks.minSize = 0;
     })
@jmsche jmsche mentioned this issue Nov 19, 2018
Merged
@jmsche
Copy link
Contributor
jmsche commented Nov 19, 2018

Hi, thanks for the notice :)

Made a PR to fix it.

javiereguiluz added a commit to symfony/symfony-docs that referenced this issue Nov 20, 2018
@javiereguiluz
minor #10686 [Encore] Fixed code example for SplitChunks (jmsche)
fd15ead 
This PR was merged into the 3.4 branch.

Discussion
----------

[Encore] Fixed code example for SplitChunks

Fixes symfony/webpack-encore#458

Commits
-------

97fbaa4 [Encore] Fixed code example for SplitChunks
@Lyrkan
Copy link
Collaborator
Lyrkan commented Nov 21, 2018

Closing this issue since the PR was merged!

@Lyrkan Lyrkan closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lyrkan @jmsche @Tim-arts
0