8000 [Encore] Fixed code example for SplitChunks by jmsche · Pull Request #10686 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Encore] Fixed code example for SplitChunks #10686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018
Merged

[Encore] Fixed code example for SplitChunks #10686

merged 1 commit into from
Nov 20, 2018

Conversation

jmsche
Copy link
Contributor
@jmsche jmsche commented Nov 19, 2018

Copy link
Contributor
@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @jmsche

@javiereguiluz
Copy link
Member

Well spotted! Thanks for fixing it.

@javiereguiluz javiereguiluz merged commit 97fbaa4 into symfony:3.4 Nov 20, 2018
javiereguiluz added a commit that referenced this pull request Nov 20, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[Encore] Fixed code example for SplitChunks

Fixes symfony/webpack-encore#458

Commits
-------

97fbaa4 [Encore] Fixed code example for SplitChunks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0