This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Don't load class cache and bootstrap file on php 7 #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @nicolas-grekas |
|
The fabbot failure is not related to my changes. |
|
When removing this from the repo, this line shouldn't be forgotten: symfony-standard/composer.json Line 33 in 1f23b3b |
|
👍 |
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Dec 6, 2016
…rabus) This PR was merged into the 3.3-dev branch. Discussion ---------- Don't load class cache and bootstrap file on php 7 As discussed in symfony/symfony#20668, the class cache features should be deprecated. Since the class cache and the bootstrap file are still useful on php 5, we load them only when running on php 5. A future php-7-only release of Symfony Standard should remove those blocks completely. Commits ------- 9b2e12f Don't load class cache and bootstrap file on php 7.
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Jan 2, 2017
…on PHP 7 (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Fix error with class redeclaration: Do not load cache files on PHP 7 Fix #411 I think this error could be related to the symfony/symfony-standard#1030 Commits ------- 13da5dc Fix error with class redeclaration: Do not load cache files on PHP 7
michaelperrin
pushed a commit
to michaelperrin/symfony-docker
that referenced
this pull request
Jan 24, 2017
michaelperrin
pushed a commit
to michaelperrin/symfony-docker
that referenced
this pull request
Jan 24, 2017
Could you please explain, what exactly did you mean? Should this line be removed or kept? |
|
@vyshkant that line should be removed if you're on php 7.0+, because it builds the bootstrap that you no longer require. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in symfony/symfony#20668, the class cache features should be deprecated. Since the class cache and the bootstrap file are still useful on php 5, we load them only when running on php 5.
A future php-7-only release of Symfony Standard should remove those blocks completely.